Coder Social home page Coder Social logo

Comments (5)

x42 avatar x42 commented on June 22, 2024

The plugin uses the exact same value for both the GUI and the inline display, there is no separate value calculated. Both GUI and inline display use the gain-factor that is used to attenuate the signal as is.

Compare the falloff from -20 to 0. It matches in both custom and inline GUI:

dpl

from dpl.lv2.

x42 avatar x42 commented on June 22, 2024

The same value (self->_peak) is used for inline display and the output port:

const float display_lvl = enable ? fmaxf (-10.f, self->_peak) : -100.f;

*self->_port[PLIM_LEVEL] = enable ? fmaxf (-10.f, self->_peak) : -10;

The latter (PLIM_LEVEL), is what is used in the GUI to draw the gain-reduction meter.

If there is a difference it could be related to display updates, redraw FPS (Ardour's inline display is updated during idle), or perhaps both are delayed respective to each other which may be noticeable with large buffer-sizes?

Either way there is nothing that can be done on the plugin's side.

from dpl.lv2.

magnetophon avatar magnetophon commented on June 22, 2024

Thanks.

The video you made actually shows the problem really well.
Turns out both the GR meter in the plugin and the inline display are wrong, imho.
Only the time graph shows the value that we are hearing, iow the correct value.
After the GR has dropped to 0dB in the graph (and the audio), the meters are still slowly dropping off.

Do you agree?

from dpl.lv2.

x42 avatar x42 commented on June 22, 2024

Yes, this is intentional.
The history display can show instant changes, however you cannot see that on the meter, that would just flicker (if at all), since an audio peak is shorter than a video-frame, you could even miss reduction.

The gain-reduction meter has dedicated ballistics: it falls off 6dB/sec. This is quite common for limiter redux meters.
Just like a needle meter, the needle cannot jump.

from dpl.lv2.

magnetophon avatar magnetophon commented on June 22, 2024

Yes, this is intentional. The history display can show instant changes, however you cannot see that on the meter, that would just flicker (if at all), since an audio peak is shorter than a video-frame, you could even miss reduction.

Right, I understand your point of view.
For me, the actual GR would still be much more informative, for 2 reasons:

  1. Currently, a big spike in the GR will mask following smaller GR's, also causing you to miss them.
  2. When I read a GR meter, I am not only interested in the amount of reduction, but also in how long it lasts, especially in a plugin with automatic release time variation, like this one. When there is only a short moment of GR, I am more interested in knowing it was short than I am in knowing how many dB it was.

I see two possible solutions:

  1. Add a switch to choose between the real and the slow GR.
  2. Speed up the fall off rate.

I strongly prefer solution 1, because solution 2 does not solve the 2nd problem.

from dpl.lv2.

Related Issues (4)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.