Coder Social home page Coder Social logo

Comments (8)

X-rayLaser avatar X-rayLaser commented on June 14, 2024

You are right. I guess I forgot to add this argument. I am working on it. That should be trivial to do.

from pytorch-handwriting-synthesis-toolkit.

daphna-kaplan avatar daphna-kaplan commented on June 14, 2024

Thank you! I found the relevant change and it is indeed very easy to implement.
I am also working on adding an "export to svg" option, I will create a request when it's ready.
By the way, I wanted to thank you personally for the GREAT documentation! I understood the project right away and managed to navigate it easily.

from pytorch-handwriting-synthesis-toolkit.

X-rayLaser avatar X-rayLaser commented on June 14, 2024

You are welcome! I am glad that you found this project useful. That "export to svg" option sounds good.

from pytorch-handwriting-synthesis-toolkit.

X-rayLaser avatar X-rayLaser commented on June 14, 2024

I have just pushed the changes. The new optional argument is called thickness. I have also updated the commands section in the Readme file to include this new option.

from pytorch-handwriting-synthesis-toolkit.

mattlevine32 avatar mattlevine32 commented on June 14, 2024

+1 on SVG export @daphna-kaplan, thanks for working on it! I have a use case where I need the SVG output to ideally only be a single SVG strokes (not a filled outline of the letters). i.e the just traces out the exact shape of the letter. Does that happen to be the same as what you're doing?

from pytorch-handwriting-synthesis-toolkit.

daphna-kaplan avatar daphna-kaplan commented on June 14, 2024

@mattlevine32 I just pushed a pr, let's see what the author thinks :)
I think you can achieve your goal with the .svg export + the new thickness parameter (I have the same need of a single line svg file)

from pytorch-handwriting-synthesis-toolkit.

X-rayLaser avatar X-rayLaser commented on June 14, 2024

@daphna-kaplan I have viewed the Pull Request. It looks good, but there are 3 tiny fixes required :).
I have left comments near relevant lines describing the issues. Let me know if you have any question.

Once those issues are taken care of, I will happily merge the changes into the main branch. Thank you for your contribution!

from pytorch-handwriting-synthesis-toolkit.

daphna-kaplan avatar daphna-kaplan commented on June 14, 2024

@X-rayLaser Pushed the changes, good calls! thank you :)

from pytorch-handwriting-synthesis-toolkit.

Related Issues (10)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.