String handling errors while generating pojos about hbnpojogen

[pharsfalvi]

Here is the patch which made it work for me

From 81c3ea3a561b980670886087da8041825b7f44cb Mon Sep 17 00:00:00 2001
From: pharsfalvi <[email protected]>
Date: Sat, 25 Oct 2014 18:23:54 +0200
Subject: [PATCH] String handling errors while generating pojos

---
 .../src/main/java/com/felees/hbnpojogen/SyncUtils.java      | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/hbnpojogen-core/src/main/java/com/felees/hbnpojogen/SyncUtils.java b/hbnpojogen-core/src/main/java/com/felees/hbnpojogen/SyncUtils.java
index dfe7df2..34fb1e5 100755
--- a/hbnpojogen-core/src/main/java/com/felees/hbnpojogen/SyncUtils.java
+++ b/hbnpojogen-core/src/main/java/com/felees/hbnpojogen/SyncUtils.java
@@ -811,6 +811,9 @@ implements Serializable {
     * @return the same string with the first character set to uppercase
     */
    public static String upfirstChar(String s) {
+        if (s == null || s.length() == 0){
+            return "";
+        }
        return s.substring(0, 1).toUpperCase() + s.substring(1, s.length());
    }

@@ -982,8 +985,9 @@ implements Serializable {
     */
    public static String removeUnderscores(String input) {
        StringBuffer result = new StringBuffer();
-
-       if (State.getInstance().disableUnderscoreConversion) {
+        if (input == null){
+            return "";
+        } else if (State.getInstance().disableUnderscoreConversion) {
            result.append(input);
        }
        else {
@@ -1292,7 +1296,10 @@ implements Serializable {
     * @return The table catalog
     */
    public static String getTableCatalog(String dottedInput) {
-       return dottedInput.substring(0, dottedInput.indexOf("."));
+        if (dottedInput.indexOf(".") >= 0){
+            return dottedInput.substring(0, dottedInput.indexOf("."));
+        }
+        return dottedInput;
    }


-- 
2.0.1

[wwadge]

Hi, thanks for the patch -- if possible can you raise a pull request? It just makes it easier to manage and track.

[pharsfalvi]

Yup, it's done. Cheers
Peter