Coder Social home page Coder Social logo

[Issue]: OpenApiV2 introspection throws error for the required params when used with discrimnator keyword for OAS3 about wundergraph HOT 3 CLOSED

bgambocjaviniar avatar bgambocjaviniar commented on May 29, 2024
[Issue]: OpenApiV2 introspection throws error for the required params when used with discrimnator keyword for OAS3

from wundergraph.

Comments (3)

Pagebakers avatar Pagebakers commented on May 29, 2024

I did some further digging and while writing the unit test I figured out the issue.

The problem is when you use allOf the top level required doesn't apply to the child schemas.

In this case - $ref: '#/components/schemas/SomeSchema' has correctly required someproprtyId

However this object schema doesn't have a require on someproprtyId

- type: object
                  properties:
                      someproprtyId:
                          type: string

The correct schema would be:

components:
     schemas:
            SomeSchema:
               required:
               - someproprtyId
               type: object
               properties:
                   someproprtyId:
                       type: string
                       ...
               discriminator:
                   propertyName: someproprtyId
                ....
            OtherSchema:
               required:
               - id
               - someproprtyId
               type: object
               allOf:
               - $ref: '#/components/schemas/SomeSchema'
               - type: object
                  required: # required needs to be added here
                  - someproprtyId
                  properties:
                      someproprtyId:
                          type: string
                  data:
                    ...

I checked this with wunderctl generate and the graphql schema is generated correctly.

from wundergraph.

Pagebakers avatar Pagebakers commented on May 29, 2024

Supplied a patch as a workaround. This is still WIP with the upstream package.

from wundergraph.

stale avatar stale commented on May 29, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from wundergraph.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.