Comments (10)
I COULD let craft 3 would I believe but we'd need to be Craft v3 but with PHP 8 and I don't even know off the top of my head if that's supported haha. It's abit annoying cos it's only a few changes in the plug-in that actually impacted but PHP 8 😩 maybe one day I can look into issue but most people are looking at Craft v4 now so there's that to consider
from oembed.
I've found this stupid bug and "fixed" it in v2.x, AKA PHP 8 version, by converting the Embed class that gets cached from a Class to JSON string and back to StdClass, I think this will be the way to go. It snapshots the object but solves the issue. Don't know WHY it started happening, probably from the core package I use, but I'm sorry this took so long to "figure out" I've just been so under the pump. This will be resolved tomorrow, it's currently 1:45am here in Melbourne, AU but turning cache off for now resolves it.
from oembed.
Just to summary the v1 branch will be updated and tagged with a new v1.x version 🍻
from oembed.
UPDATE: This appears to be related to the PHP version.
Works OK on PHP 7.4 but throws the error on PHP 8.1
from oembed.
THis should be resolved in the 2.0.0 release soon
from oembed.
Hi @reganlawton -
I'm seeing this error on PHP 8 and Craft 3 with version 2.0.0 1.3.15.
Is there any plan to fix on the Craft 3 release?
from oembed.
It's not possible 2.0.0 is branch for Craft v4 the composer.json shouldn't never let Craft v3 install cos the plug-in extended classes require PHP 8.0.2 minimum via Craft v4. This is why I set a MAJOR release and not a MINOR version. It's weird that your trying to install v2.0.0 if your using Craft v3 🤔
from oembed.
You should set the composer.json to ^1.3.0 or something to keep it too v1 which will be the future fixes for Craft v3
from oembed.
Thanks @reganlawton
Oh no, I'm still on 1.3.15
and wasn't trying to install 2.X
(I had read the release number on the Github page, so my previous comment was wrong!), I only recently saw this error on PHP 8 and Craft 3.
I've probably had the bug a while but just not noticed it before, although thankfully it doesn't affect many pages. 😬
from oembed.
Ok sure thing 🙌
from oembed.
Related Issues (20)
- Cache tweets HOT 2
- Further changes required for GDPR compliance HOT 4
- Video preview very small HOT 2
- Division by zero error in both backend and frontend HOT 4
- ignores time #t=1m12s HOT 4
- Vimeo URLs not working (when video is set to be hidden on Vimeo.com) HOT 1
- Field always renders as if it has content HOT 2
- Field causes template to crash if left blank HOT 3
- Issue when using oEmbed in Vizy block HOT 3
- v3 does not return `.images` and other API data HOT 10
- Additional data missing for media objects HOT 11
- How do we get the media data with the new update? HOT 7
- Looping a video HOT 6
- YT/Vimeo media URL blank after upgrading to 3.x HOT 3
- Google Maps Error: www.google.com refused to connect HOT 1
- Large quantities of embed-cookies-{uid} are being created, but not deleted? HOT 1
- possible to display Youtube thumbnail before user gives cookie consent? HOT 2
- Vimeo URLs not working in any environment HOT 28
- GrapQL - Error when querying an entry with a empty oEmbed URL
- oEmebed resources not loaded in Craft Cloud environment HOT 17
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from oembed.