Comments (9)
Hey @hatsumatsu, thanks for reporting this! We are working on a newer version of the GraphQL IDE and have also tracked this over there (wp-graphql/wpgraphql-ide#90)
from wp-graphql.
Hey @hatsumatsu, thanks for reporting this! We are working on a newer version of the GraphQL IDE and have also tracked this over there (wp-graphql/wpgraphql-ide#90)
Confirming we also need to address this in core as a regression of #3067 , since the timeline for bringing in the new IDE isn't short-term(?)
from wp-graphql.
Confirming we also need to address this in core as a regression of #3067
@justlevine I'm not sure this actually is a regression 🤔 I've not been able to reproduce it at all.
from wp-graphql.
I'm unable to reproduce this using the above steps with no plugins installed except for WPGraphQL 1.22.1 using WordPress 6.5.
@hatsumatsu Please confirm you have tested without other WordPress plugins active 👍
from wp-graphql.
@hatsumatsu I am also unable to reproduce. When I have "Show Avatars" setting set to "off", I still see my gravatar:
And when I'm using the IDE as a user that does not have a Gravatar, I see a fallback user icon:
from wp-graphql.
Confirming we also need to address this in core as a regression of #3067
@justlevine I'm not sure this actually is a regression 🤔 I've not been able to reproduce it at all.
@jasonbahl I didn't test or triage, was solely responding to this comment about tracking it in wpgraphql-ide
i.e. bugs (if found) need to be handled in this repo as well.
from wp-graphql.
@jasonbahl Thanks for looking into this.
It might be related to my custom starter theme that immediately disables avatars upon activation:
add_action( 'after_switch_theme', function() {
update_option( 'show_avatars', '' );
} );
https://github.com/hatsumatsu/Port-F
If you disable avatars at a later point, the data and images might already be present in the database.
from wp-graphql.
@hatsumatsu Thanks for providing more info regarding your setup!
I am still having trouble reproducing this issue, however here is my suggestion for your situation - load custom styles when on the IDE page and avatars are disabled:
add_action( 'enqueue_graphiql_extension', function() {
$show_avatars = get_option( 'show_avatars' );
if ( '0' !== $show_avatars && '' !== $show_avatars ) {
return;
}
?>
<style>
[data-testid="auth-switch"] .toolbar-button span.ant-avatar-image::before {
content: "\f110"; /* Dashicons user icon */
color: #444;
font-family: "Dashicons";
display: inline-block;
font-size: 20px;
vertical-align: middle;
margin-right: 5px;
}
</style>
<?php
});
I hope this helps 🙌
from wp-graphql.
Closing this as we weren't able to reproduce this without any additional plugins active. A possible solution has been provided above. If there's evidence that this is still a bug to be addressed feel free to open a new issue with as much detail as possible (and reference this issue). Thanks!
from wp-graphql.
Related Issues (20)
- Upgrade webonyx/graphql-php to 15.x HOT 2
- Unable to Make Menus and Menu Items public HOT 6
- v2.0 Roadmapping
- Introduce actions/filters for the `register_graphql_admin_notice` API
- DX: Can't narrow down interface subtypes on an implementing object with `register_graphql_field()` HOT 2
- Add WordPress new `Site Icon` feature to generalSettings. HOT 2
- WPGraphql fetching duplicated nodes in Gatsby HOT 7
- Interface Recursion Issues HOT 7
- Open SSF Scorecard
- Arguments defined on Interface Fields are not inherited by the fields on the Implementing Object Type HOT 1
- Codegen issue in generating types: Interface field argument ProductWithPricing.price(format:) expected but GroupProduct.price does not provide it. HOT 4
- Node IDs not being tracked by the Query Analyzer when using DataLoader's `load_many()` method HOT 1
- Missing field argument lead to broken Documentation Explorer HOT 2
- Remove development-related files from SVN on release
- CoreTable column alignment returns null HOT 2
- Can't add mutation for urls gallery. HOT 1
- PostFormat is not set when Contribute/Author uses createPost or updatePost mutations HOT 3
- Settings page fails to load when "Enable GraphiQL IDE" setting is turned "off"
- Bug: graphql_get_setting_section_field_value filter params return different types than documented
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wp-graphql.