Coder Social home page Coder Social logo

Comments (1)

jrfnl avatar jrfnl commented on June 11, 2024

I've done the prep work to implement this and am left with 9 issues for which I'd like the opinion of one of the maintainers of this package on how to solve this. /cc @schlessera

  • 5 issues related to whether or not some (protected, not private) properties should be safe to rename.
  • 4 issues about strict comparisons - I know how to change it, but can't easily determine whether these would be safe to change without tracing through the code extensively, which is why I'm asking if someone has a quick answer.
FILE: inc\checks\class-check.php
------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
------------------------------------------------------------------------------------------
 14 | WARNING | Property name "$_when" should not be prefixed with an underscore to
    |         | indicate visibility (PSR2.Classes.PropertyDeclaration.Underscore)
 23 | WARNING | Property name "$_status" should not be prefixed with an underscore to
    |         | indicate visibility (PSR2.Classes.PropertyDeclaration.Underscore)
 30 | WARNING | Property name "$_message" should not be prefixed with an underscore to
    |         | indicate visibility (PSR2.Classes.PropertyDeclaration.Underscore)
------------------------------------------------------------------------------------------


FILE: inc\checks\class-file-contents.php
------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
------------------------------------------------------------------------------------------
 34 | WARNING | Found: ==. Use strict comparisons (=== or !==).
    |         | (WordPress.PHP.StrictComparisons.LooseComparison)
 49 | WARNING | Found: ==. Use strict comparisons (=== or !==).
    |         | (WordPress.PHP.StrictComparisons.LooseComparison)
------------------------------------------------------------------------------------------


FILE: inc\checks\class-file.php
------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
------------------------------------------------------------------------------------------
 15 | WARNING | Property name "$_when" should not be prefixed with an underscore to
    |         | indicate visibility (PSR2.Classes.PropertyDeclaration.Underscore)
 47 | WARNING | Property name "$_matches" should not be prefixed with an underscore to
    |         | indicate visibility (PSR2.Classes.PropertyDeclaration.Underscore)
------------------------------------------------------------------------------------------


FILE: inc\checks\class-option-value.php
------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
------------------------------------------------------------------------------------------
 44 | WARNING | Found: ==. Use strict comparisons (=== or !==).
    |         | (WordPress.PHP.StrictComparisons.LooseComparison)
 52 | WARNING | Found: ==. Use strict comparisons (=== or !==).
    |         | (WordPress.PHP.StrictComparisons.LooseComparison)
------------------------------------------------------------------------------------------

from doctor-command.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.