Comments (10)
@wouterpeere I'll update my test 3 file to display all the different sizes. I haven't done the sensitivity analysis for test 4 yet, but I'll implement the code for it today and include the analysis of the different tests in the documentation (https://docs.ghetool.eu/en/latest/sources/code/validation.html).
from ghetool.
@LoneMeertens I have made everything compatible with the newest version of GHEtool and I added some asserts to the documents as well. I noticed that both the sensitivity of test 4 and the different sizes of test 3 are not yet implemented. Do you have that somewhere already?
Best,
Wouter
from ghetool.
@LoneMeertens
Any progress on the documentation?
from ghetool.
@wouterpeere Yes, I have worked on the documentation offline and will finalize it soon. While writing this documentation, I wondered if there could be an additional uncertainty regarding the modification of the constraints for the maximum fluid temperature. Currently, the delta T is calculated based on the maximum peak load. The two uncertainties that came to mind are:
- Does the maximum/minimum temperature always occur during peak load? In scenarios where the peak load is isolated, this doesn't seem to be the case.
- The same delta T is used for both the upper and lower constraints. Shouldn't we consider two different delta T values, one for the maximum cooling peak and another for the maximum heating peak?
from ghetool.
- This is only the case in L2 methodologies, in L3/L4 the temperatures are calculated for every month, regardless of its peak power.
- I do not understand what you mean by 'delta T'. Do you mean: 'the difference between the fluid threshold and the ground temperature'? In that case, can you point to the exact lines where you think there is a mistake? Normally size_L2/L3/L4 does this.
from ghetool.
For testa1a.py (analogous for other tests), I am referring to lines 44-48 for both questions:
- When the peak temperature does not occur during the peak power hour, sizing with L3/L4 will still size based on a temperature limit constraint that is transformed based on peak power. Aren't the upper/lower fluid temperature limits therefore too high/low in this case?
- The formula
delta_t = max(load.max_peak_cooling, load.max_peak_cooling) * 1000 / (fluid_data.Cp * fluid_data.mfr)
is currently used to modify the temperature constraints. The same delta_t is applied to both the upper and lower limits. The upper limit is constrained based on the building's cooling demand, while the lower limit is constrained based on the heating demand. Shouldn't two different delta T values be applied to the lower and upper limits on the fluid temperature respectively?
from ghetool.
Hi @LoneMeertens , I see. I thought you were talking about main methodologies.
- You're right. This will lead to more critical temperature limits (peak power will give highest delta T and hence more critical limits). It can be that this give rise to an oversizing, although I think the effect would be minimal. To solve this, we would need a methodology in GHEtool to size for inlet/outlet temperature, so it can be mass flow dependent.
- Also right. You can indeed change that, although I do not think this will make a big difference as well, but it is more accurate for sure ...
from ghetool.
@wouterpeere I will run the different tests with the changes discussed in item 2 and report back here.
from ghetool.
@wouterpeere, I've updated the validation page on RTD. Please inform me if further clarification is required or if we can proceed to close this issue.
from ghetool.
Hi @LoneMeertens ,
Thanks! I will review it and close this issue!
Best,
@wouterpeere
from ghetool.
Related Issues (20)
- Change temperature db to JSON
- Optimise load profile - hourly method
- Coaxial with different pipe conductivities
- Rename main_class
- Remove parameter Tf
- Option to include/exclude dhw from peak heating
- Small errors in optimise_load_profile_energy
- Exclude DHW from peak heating
- Skopt depreciated
- Wrong load duration curve
- Add volume flow rate
- Add yearly heating/cooling load/peak
- Cleanup Borefield.py
- Size with inlet or outlet temperatures
- Optimise load profile with DHW
- DHW profile HOT 1
- Unit-tests run only for 3.12 HOT 1
- optimise load profile with max power
- Pressure drop
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ghetool.