Export IL about worldskills-infrastructure-list

[fabian]

@worldskillsfrance Ah yes, that's a bug, thanks! Fixed now on staging. Will deploy to production on Monday.

[fabian]

@ailtisWSFR I've added Energy and Electricity to the "global exports".

[PierreAnctil]

closely related to #8

[Simon-Woirgard]

@PierreAnctil
When we do an extract with "Requested items" tool we only have the field written quantity. We should also have the column sum of "Quantity" multiplied by the "Multiplier" as we have in all other extractions.

[Simon-Woirgard]

Hi @fabian @gbervik ,

there is also a bud when we extract data from a skill : (requested items for skill)
files are not on the good colom

Could you have a look to fix that please ?
(I think this happens in other extraction possibilities for exemple "Export all Requested Items")
When you will fixe that could you tell me because there translation mistake and i need to get back to Axiocode to fixe that too thx

[PierreAnctil]

@worldskillsfrance I added the computation on quantity (code review pending)

[fabian]

@worldskillsfrance Okay, I've merged the calculated quantity and added the missing unit column header. Deployed to production.

[Simon-Woirgard]

@fabian there is still some bug in extraction i guess all colonne are in the right place as you can see below :

data in "PO number" in colonne AC should be in the colonne AD also the same with AI

[Simon-Woirgard]

Hi @PierreAnctil
Please find below a video (who start at 20sec) about several bug of extraction. Could you have look/answer/fix all bug.
https://www.dropbox.com/s/ynb0j6cc8u3aoju/Bug%20extraction.mp4?dl=0
Waiting for you retourn

[PierreAnctil]

As discussed the description issue is addressed in #89

Factor is

Part number is

I submitted a fix for the supplier which was the supplied item supplier. Now it will be the requested item potential supplier. (https://github.com/worldskills/API-Infrastructure-List/pull/33)

I also submitted a fix for the energy. Note that after consulting @fabian I harmonized the meaning of energy with the rest of the application and now air and electricity are considered energy but not water. (https://github.com/worldskills/API-Infrastructure-List/pull/33)

I checked with a fully inputed item and all the columns are filled correctly.

[ailtisWSFR]

@PierreAnctil Thanks for those explanations.
I do understand the issue #89 explaining the empty column for "Description".

From the video, 2 bugs remain:
1 - I understand now the "Factor" column, but the traduction should be "Multiplicateur" instead of "Facteur" to be understood correctly and match the traduction of the tool "Add item". Thanks in advance to change that.
2 - The column "Energy" has disappeared from the export now. I understand and agree with @fabian about the harmonization of the meaning "energy". But at least we need the information about the "Electricity" to appears as well, the same as the column "Air" with the "N" or "Y".
Could you please have a look at that and add the "Electricity" column on the export?

Thanks

[fabian]

@ailtisWSFR I have just deployed some fixes from @PierreAnctil to production. Please check again if the export still has issues.

[ailtisWSFR]

@fabian @PierreAnctil The export still has issues : Still no "Electricity" column

@PierreAnctil you can forget the change about "Facteur", I've realized that another column already has the name "Multiplicateur". Sorry for that.

[PierreAnctil]

@ailtisWSFR I've just made an export in production and the columns energy and electricity are here:

Maybe you are not talking about the export described in this issue (export in the requested items search page) but rather about the global export on the main page?

[ailtisWSFR]

@PierreAnctil Yes, sorry, I'm talking about the global export. I thought that this issue was about all the IL's export. Still, the bug remains and need to be fixed.

[PierreAnctil]

@ailtisWSFR Well it's not exactly a bug since no one ever expressed the need to have this column here. It has also nothing to do with Axiocode developments so I suppose @worldskills/geeks should take care of it. Finally this should be put in a separate issue since it is not related to the new export described here.

[fabian]

@ailtisWSFR Can we close this issue?

[ailtisWSFR]

@fabian Yes, we can. Thanks.