Comments (1)
Thanks for the suggestion Ruth. I agree with your suggestion. In addition I think we should flash a message indicating they have already reviewed the course and add a link to the edit page.
For some more context, the visit review
link is hardcoded into the flash message in the editreview.html
template. It will always show a link to the review regardless of the message. This was originally implemented so that you would have a link after editing so that you could see the review - however, it's not always that relevant (such as this situation). Ideally it should probably be part of the message sent from the server (only included when relevant) but it wasn't clear to me how to ensure it rendered as link instead of text.
from compass.
Related Issues (20)
- JS error on account creation HOT 4
- Cannot retrieve any full review HOT 1
- Non user-friendly error when review comment is too large HOT 2
- Add sanitization and validation on inputs
- Add pagination on review pages
- Stores sessions in database
- Feature request: "Report" button next to reviews
- Feature request: "Add a review for this course" button on course page
- Highlight if data is not found
- Problems with Displayed Text HOT 2
- Add TLS support HOT 1
- Break routes into separate files
- Bug: if supplied session doesn't exist in database then server crashes instead of asking user to login again
- Reduce size of headings in generated HTML of markdown reviews HOT 2
- Add Markdown Editor
- After a 500: internal server error, going back loses the module and session and unable to select original without selecting another first HOT 1
- Improve UI of review cards
- Add personalized dashboard for tracking modules
- Escape all values in HTML HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from compass.