Comments (17)
@jasmussen I've changed this locally and will push shortly, but there's an awkward behavior now where the "View all patterns ->" link (going to the archive) no longer shows all patterns, and in fact repeats most of the patterns you've just seen.
Homepage | Archive page |
---|---|
![]() |
![]() |
from pattern-directory.
Thanks for the work, and appreciate the screenshots.
That is awkward, yes. I wonder, was there any context for the addition of the "View all patterns" CTA on the landing, vs. just showing pagination right there? Would that be an option?
from pattern-directory.
Initially this grid was meant to be the curated section, and then the Archive showed the full listing of patterns, like from Showcase. This was done to set the stage for other featured sections in the future, like pattern bundles, if/when those are built.
from pattern-directory.
Perhaps the "All" on the homepage should not be selected. Then when you click "All" or "View all patterns", you are taken to the archive page.
![image](https://private-user-images.githubusercontent.com/4832319/323346885-64d7aca5-7ac2-4498-a97a-e05735a8c918.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTQ5MjQyOTEsIm5iZiI6MTcxNDkyMzk5MSwicGF0aCI6Ii80ODMyMzE5LzMyMzM0Njg4NS02NGQ3YWNhNS03YWMyLTQ0OTgtYTk3YS1lMDU3MzVhOGM5MTgucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDUwNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA1MDVUMTU0NjMxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MjAzOGRjZWVkMDcwZjBkNDRjZDViNGUxNTc0YmMwNTU4MGFkMjUxMWUyNDE3YzU0YTZhOTBkYzRhMTFjYzc3MSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.-FVfvpAYJ8nLFL0gLGU9__usGfUGxPilcUkV-4cDHac)
from pattern-directory.
Would that still default to "curated"?
from pattern-directory.
Would that still default to "curated"?
Yeah, I think so for this iteration. That keeps parity with the current site.
from pattern-directory.
I'm not sure if that helps — the issue is still that clicking the "View all patterns" link in the footer will show you all the same patterns.
from pattern-directory.
One possible thought would be to include the "curated" and "community" in the pattern number:
![image](https://private-user-images.githubusercontent.com/4832319/323348390-ce47128d-d030-41f2-9f5e-b49e51fead04.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTQ5MjQyOTEsIm5iZiI6MTcxNDkyMzk5MSwicGF0aCI6Ii80ODMyMzE5LzMyMzM0ODM5MC1jZTQ3MTI4ZC1kMDMwLTQxZjItOWY1ZS1iNDllNTFmZWFkMDQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDUwNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA1MDVUMTU0NjMxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9OThjNTk4ZjA5YmMyMDU0NGMzMGE1ZTQ5MzZhMzEwYjE0YmY2YWQxZmQxMmRiY2NjNjQ2MTRkMWE0NDkxZjJkMiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.pEIuIY00vpMwdJflzt28YvAutkg8lI2FuQHnLK1ru9c)
That makes it a bit clearer what you are viewing. The "All" section would just be "XX patterns"
from pattern-directory.
Oh, that made me realize— there's also the issue that the query total is different now. On the homepage, it's the count of all patterns ("1,875 patterns") but on the archive page it's just the count for the current query, i.e., curated patterns ("43 patterns"). I suppose adding "curated" would fix that issue.
The "All" section would just be "XX patterns"
We don't really have an "All" section anymore — you can technically select "All" out of the filter options dropdown, but now clicking "All" will take you to curated patterns.
from pattern-directory.
We could change the "View all patterns" link to use https://wordpress.org/patterns/archives/?curation=all
— so the top category links would all use "curated" as default, but if you've specifically clicked that link it will show all…? But then if you click any other category once on that page it flips back to curated, so maybe not.
from pattern-directory.
We could also remove that link entirely? Let users navigate using the top row of categories only.
from pattern-directory.
We could also remove that link entirely? Let users navigate using the top row of categories only.
I'm inclined to keep the "All" in the categories row, at least for now, since it's on the current site.
from pattern-directory.
I'm inclined to keep the "All" in the categories row, at least for now, since it's on the current site.
Yes, that would stay in place. I'm just talking about the "View all patterns" link above the footer on the homepage.
![Screenshot 2024-04-17 at 3 42 32 PM](https://private-user-images.githubusercontent.com/541093/323357937-dc321cc1-257a-46d1-9331-6994853b6805.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTQ5MjQyOTEsIm5iZiI6MTcxNDkyMzk5MSwicGF0aCI6Ii81NDEwOTMvMzIzMzU3OTM3LWRjMzIxY2MxLTI1N2EtNDZkMS05MzMxLTY5OTQ4NTNiNjgwNS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNTA1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDUwNVQxNTQ2MzFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0yNDI3ZGM4M2Y0ZGQ3MTVkYjhjY2VlMjNjNTNjYjIxOTg0NmI1OTk5OTgwOTJlMDRkMGQ2ZWZhNDJiNTgyODMyJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.-ANxNiWpl86D2KYJHXxhbVFpG0b5D4-hkdsrD8kjyf4)
from pattern-directory.
This older design doesn't include the "View all patterns" link at the bottom, essentially dives right into the full paginated list of all patterns, just as the current directory does, and the tabs simply filter that curation into subcategories.
I think there are a lot of opportunities for improvements across filters, categories, improving guildelines for submission, better author profiles, pattern bundles, endless good ideas to explore. But many of those are larger, and could use good and broad input and consideration. In the mean time, it would be good to find the simplest path forward, in case that means removing the "view all patterns" link, and just showing the pagination directly, as is the case on the existing version.
from pattern-directory.
"Just showing the pagination" is more complicated than it sounds, because the new theme was set up to use a separate page for the homepage. I realize I didn't complete the thought here, but that was intended to explain that we can't use pagination here, because the home and archive are two entirely separate queries/pages.
I'm trying to switch that now to see if we can bring in pagination, but I need to remove all references to the archives page, which is harder than a simple swap.
from pattern-directory.
Archives page is officially gone now. I think I've checked all the paths that could have lead there, so there should be no dead ends. The homepage has pagination on it, and all views default to only showing curated patterns (except author archives).
from pattern-directory.
"Just showing the pagination" is more complicated than it sounds
Apologies, I should've learned by now to never use the term "just" in software development. This was my bad.
from pattern-directory.
Related Issues (20)
- Block theme: Clicking category on favorites takes you to category archive HOT 1
- Block theme: Sort label is displaying as the dropdown title.
- Block theme: Archive, Category and Search pages don't have an `h1` tag.
- Block theme: Report button alignment on mobile. HOT 2
- Block theme: Author view sub nav menu includes query parameters on scroll down.
- Block theme: using category nav bar on favorites (or author view) navigates me away. HOT 1
- Block theme: How do I clear my filtered search? HOT 6
- Block theme: No way to identify author if they only have 1 pattern. HOT 4
- Block theme: Link pattern author name to archive HOT 6
- Block theme: Extra space above and below the pattern preview on mobile HOT 3
- Block theme: Allowing users to clear the search form and submit. HOT 8
- Block theme: Keep search term when changing categories. HOT 4
- Block theme: Standardize star color for favorites HOT 2
- Add tooltip about some blocks not triggering "Upload external images" HOT 4
- Block theme: Applying "all" filter and searching for term resets to "curated". HOT 1
- Post List Continuously Loads without Displaying Posts in Pattern Creation Too
- Patterns have a different viewport width than the default in core HOT 3
- Tools: Unify github build workflow and sync scripts for new block theme
- Add "Intro Area with Heading and Image" pattern as a core pattern HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pattern-directory.