Coder Social home page Coder Social logo

Comments (12)

Ipstenu avatar Ipstenu commented on August 16, 2024 2

Rejections are kinda saved -- everyone who has a rejected plugin, has it listed on the 'author' card:

Screen Shot 2020-11-11 at  11 Nov - 12 12 11 PM

And everyone gets an email (except for 'it's been 6 months...'). As you can see, we don't track 'why' something was rejected. Most of the time we use it for "We've rejected Bob for the same plugin 3 times. Check the emails and see if he's just not getting something or if we have a bigger issue."

In general, rejections are:

  • Submitter took 6 months and never finished the review
  • Plugin is not acceptable
  • Specific issue with submitter

from pattern-directory.

tellyworth avatar tellyworth commented on August 16, 2024 2

@MichaelArestad raised the interesting idea that people might like to use this as a repository for their own patterns. For example a designer or integrator might keep a library of patterns for easy access on their client sites.

We won't have any way to authenticate users from an external editor, which means they can't be completely private. But I wonder if this hints at a more nuanced set of statuses than for the plugin/theme directories. Something like:

  • I create/remix a pattern and save it.
  • It's now accessible to me (as author) on the front end of the directory, but not visible there to others or logged-out users.
  • From the Gutenberg editor on my site, I can search for my pattern with some kind of explicit prefix, like "user:tellyworth green button"
  • If I want to publish it to the world, I can go back to the directory and "submit".
  • If it's reviewed and accepted, it becomes visible on the directory front end and searchable from the pattern tab in the editor as "green button".
  • If it's declined or still pending review it stays in the "private" state.

That suggests something slightly more complex than 3 status values.

from pattern-directory.

iandunn avatar iandunn commented on August 16, 2024 1

rejected

The Community Team uses declined as a softer word in those situations, and I think it's worked well there.

from pattern-directory.

iandunn avatar iandunn commented on August 16, 2024 1

How should a user get to this page?

I think the only way to see all of your plugins is on profiles.w.org. I think it'd be good to add patterns there, for consistency.

I don't think that's easy to find, though. I like how the 5ftF design has a My Pledges link in the navbar. That could link to the patterns on the profile, so we don't have to create duplicate pages.

from pattern-directory.

iandunn avatar iandunn commented on August 16, 2024

Is there something similar for plugins?

The Add Your Plugin page will show everyone how many are in the review queue, but I think the accepted/rejected notes are sent via email.

Is that right, @Ipstenu ?

from pattern-directory.

MichaelArestad avatar MichaelArestad commented on August 16, 2024

@tellyworth Exactly. I don't think we need to start with that feature as a priority, but down the road, it could be a nice enhancement.

from pattern-directory.

carolinan avatar carolinan commented on August 16, 2024

Please consider allowing contributors to remove and transfer their patterns as well.
I don't know how the plugin team handles it but for themes this process is manual.

from pattern-directory.

ryelle avatar ryelle commented on August 16, 2024

Design for "My Patterns"

Pending Review
Successfuly Published

There's also more information, including an edit button, in the header of owned pattern details. The note about transferring ownership & removal is a good point, @shaunandrews where do you think that could fit in?

Pattern Detail - Owned - Pending

from pattern-directory.

shaunandrews avatar shaunandrews commented on August 16, 2024

Instead of a single "Edit" button, perhaps we show a menu with multiple options including transferring ownership and deleting:

image

We can also expose this menu in the grid view of patterns:

image

from pattern-directory.

ryelle avatar ryelle commented on August 16, 2024

To do here (create individual issues before tackling):

  • Create the My Patterns page
  • Update the grid component to separate it from the main query, so we can have multiple grids on one page
  • Show the user's patterns in a grid (if any)
    • Allow filtering by status
    • Patterns should have a status label #103
  • Show the user's favorites in a grid (if any)

My Patterns

In the design, there is one pagination, but two queries — should we show all owned patterns, and paginate favorites? or somehow paginate both? Or maybe we should create two pages after all, "my patterns" and "my favorites"?

What does the "featured" dropdown do in the favorites grid?

from pattern-directory.

shaunandrews avatar shaunandrews commented on August 16, 2024

there is one pagination, but two queries — should we show all owned patterns, and paginate favorites? or somehow paginate both? Or maybe we should create two pages after all, "my patterns" and "my favorites"?

My intention with the design was that each group would be it's own query, each with their own pagination. This is obviously not great, especially if we consider someone with more than a handful of both owned patterns and favorites. I think we should just split these up after all:

image

"My patterns" gets a button to create a new pattern, a filter for status, and a sort menu. "Favorites" has a category filter (maybe only show the categories that exist within the collection) and a sort menu.

What does the "featured" dropdown do in the favorites grid?

That's the "sort by" menu, which allows you to control the order of the items in the grid. In the context of "My patterns" and "Favorites" I think the options should be date (last updated), views, and favorites. The featured option doesn't really make sense on these screens.

from pattern-directory.

ryelle avatar ryelle commented on August 16, 2024

An issue was created for the favorites page - #239. The remaining task for this issue is the management dropdown.

from pattern-directory.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.