Coder Social home page Coder Social logo

Comments (5)

ryelle avatar ryelle commented on July 17, 2024 1

I added the preview link as a possible location for both desktop/mobile preview as well as maybe theme switching.

I always forget it does that because that's never behavior I want when writing — but it makes much more sense here 👍

from pattern-directory.

StevenDufresne avatar StevenDufresne commented on July 17, 2024 1

Should the editor have a different icon/header/something to indicate it's the pattern submission tool and not the regular editor on one of the user's sites?

I have tried using the block-editor template/template-part maker for Full Site Editing, along with generating a pattern using #21 and I am consistently confused when I get to the block-editor. It's very difficult to understand the context. I think Gutenberg is going to need a way to better identify the context within the block editor or all these parts are going to end up rolling their own views (which we probably don't want). It may make sense to open a ticket in Gutenberg asynchronously to get the conversation going.

from pattern-directory.

ryelle avatar ryelle commented on July 17, 2024

In #21 I set up the viewportWidth as a dropdown of fixed widths (narrow: 800, wide: 1100, extra wide: 1400) — I'm not sure there's much benefit in letting people control this to the pixel, but maybe the slider could snap to the 100s or 50s?

Should the editor have a different icon/header/something to indicate it's the pattern submission tool and not the regular editor on one of the user's sites?

Is the full screenshot the entire page, or do you still expect to have the WordPress.org wrapper around the content like this (except not a hacky photoshop 🙂 )
Screen Shot 2020-11-10 at 7 02 33 PM

Are there controls we should remove from the editor (like block installation)?

When I was building the proof-of-concept, I took the opposite approach, starting at just content editor and adding to it. So I think the inserter with only core blocks (for now(?)), undo/redo, and the selection modes (maybe) are all that's needed. Preview also doesn't make sense here, since this is the preview.

from pattern-directory.

MichaelArestad avatar MichaelArestad commented on July 17, 2024

I set up the viewportWidth as a dropdown of fixed widths (narrow: 800, wide: 1100, extra wide: 1400) — I'm not sure there's much benefit in letting people control this to the pixel, but maybe the slider could snap to the 100s or 50s?

@ryelle Right! The slider would snap to 100s (or whatever feels good there).

Preview also doesn't make sense here, since this is the preview.

Ah yes. I added the preview link as a possible location for both desktop/mobile preview as well as maybe theme switching. Def not needed right away.

from pattern-directory.

ryelle avatar ryelle commented on July 17, 2024

Closing this issue - the panel exists, and we can review the content inside in another issue (if needed).

from pattern-directory.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.