Comments (4)
We will be showing an error and gracefully exiting for now. If we find there is demand for using the progress output with a large number of workers on small terminals, we will revisit the other options.
from wordfence-cli.
Verified the --progress output now fails gracefully in the event that the terminal is too small to display the requested number of workers, and continues to perform as expected when the terminal window is an adequate size. This includes the following:
- various number of workers ranging from 1-8 completed as expected
- various numbers of workers ranging from 9-200 failed with the error message "The current terminal size is inadequate for displaying progress output for the current scan options"
- resizing the terminal window while a scan is running or once a scan completed fails with the error message above.
- scanning without --progress continues to produce expected results
- additionally confirmed that the numbers with and without using the --progress option match between total files scanned and results found
- additionally confirmed the output is populating as expected with a large number of malware files found by scanning traditionally and with --progress option
from wordfence-cli.
New display error found. When selecting a number of workers that maximizes the terminal window size (see screenshot), the box for scan results is obscured and progress output ends abruptly with error message: Error: 'LogBox' object has no attribute 'cursor_offset'
.
Instead, allow only enough workers that will allow the results window to display in a minimum set size, and allow the progress output to fail with the error message "The current terminal size is inadequate for displaying progress output for the current scan options" as we do if the amount of workers does not fit on screen.
from wordfence-cli.
Tested with a variety of workers on both a laptop monitor and an external monitor. Verified workers and scan results screens display when able or else fail with the error message The current terminal size is inadequate for displaying progress output for the current scan options
. Additionally retested the following:
- resizing the screen to both too small for output to display (fails as intended) or to a size that repositions the workers on screen
- scanned small and large amounts of malware findings
- multiple scans performed with various options including defined output-path, various number of workers, stderr routed to error log, stdout, allow-io-errors, include-files-pattern, and chunk-size.
from wordfence-cli.
Related Issues (20)
- New Wordfence CLI install produces "Latin-1" UnicodeEncodeError HOT 11
- CLI misses malware reported by plugin HOT 2
- Implement vectorscan support to improve malware scan performance HOT 9
- On MacOS, when you remediate one or more files and enable debug logging, FileType.<TYPE> is output HOT 1
- Feature Request: Add argument to skip api.github.com version check HOT 2
- Inconsistent exit code with remediate depending on if install via pip or binary HOT 2
- Missing RPM from the crb repo HOT 2
- Add public contribution and security guidelines
- Add option to limit CPU usage for malware scans
- Non-ASCII characters in filenames can result in encoding errors HOT 9
- Error: 'bytes' object has no attribute 'encode' HOT 7
- Error: 'utf-8' codec can't decode byte 0xfc in position 62: invalid start byte HOT 7
- File name filtering error HOT 1
- Document `--email` file attachment capability HOT 3
- Remove version number from tracked file
- Use a specific/identifiable user agent when making requests to Wordfence APIs
- Gracefully handle rate-limited responses from the Wordfence APIs
- Change to how CLI Premium license expirations are handled in Wordfence CLI
- Error: Can't mix bytes and non-bytes in path components.
- Enhancement: Scan crontab for malicious jobs
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wordfence-cli.