Coder Social home page Coder Social logo

Comments (4)

akenion avatar akenion commented on September 28, 2024

We will be showing an error and gracefully exiting for now. If we find there is demand for using the progress output with a large number of workers on small terminals, we will revisit the other options.

from wordfence-cli.

ewodrich avatar ewodrich commented on September 28, 2024

Verified the --progress output now fails gracefully in the event that the terminal is too small to display the requested number of workers, and continues to perform as expected when the terminal window is an adequate size. This includes the following:

  • various number of workers ranging from 1-8 completed as expected
  • various numbers of workers ranging from 9-200 failed with the error message "The current terminal size is inadequate for displaying progress output for the current scan options"
  • resizing the terminal window while a scan is running or once a scan completed fails with the error message above.
  • scanning without --progress continues to produce expected results
  • additionally confirmed that the numbers with and without using the --progress option match between total files scanned and results found
  • additionally confirmed the output is populating as expected with a large number of malware files found by scanning traditionally and with --progress option

from wordfence-cli.

ewodrich avatar ewodrich commented on September 28, 2024

New display error found. When selecting a number of workers that maximizes the terminal window size (see screenshot), the box for scan results is obscured and progress output ends abruptly with error message: Error: 'LogBox' object has no attribute 'cursor_offset'.

Instead, allow only enough workers that will allow the results window to display in a minimum set size, and allow the progress output to fail with the error message "The current terminal size is inadequate for displaying progress output for the current scan options" as we do if the amount of workers does not fit on screen.

image

from wordfence-cli.

ewodrich avatar ewodrich commented on September 28, 2024

Tested with a variety of workers on both a laptop monitor and an external monitor. Verified workers and scan results screens display when able or else fail with the error message The current terminal size is inadequate for displaying progress output for the current scan options. Additionally retested the following:

  • resizing the screen to both too small for output to display (fails as intended) or to a size that repositions the workers on screen
  • scanned small and large amounts of malware findings
  • multiple scans performed with various options including defined output-path, various number of workers, stderr routed to error log, stdout, allow-io-errors, include-files-pattern, and chunk-size.

from wordfence-cli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.