Cordova iOS 7.0.0 installation problems about wonderpush-cordova-sdk

[ofavre]

Hi,

I wonder where those quotes come from.

Can you try to:

1. Find the file where those quotes come from: grep -F -e '"com.app.demo"' -R .
2. Remove the quotes. If it does not work, remove the quote in the middle and place it in the end, before the ;
3. Try to build

If the issues comes back can you find a reproduction to make those quotes appear, we'll then be able to fix our hook.

[phillipplum]

Hello,
I've finally been able to do some testing.

If I add the iOS platform completely new and do not install Wonderpush Cordova SDK I find the following results:

./platforms/ios/Demo.xcodeproj/project.pbxproj:  PRODUCT_BUNDLE_IDENTIFIER = "com.app.demo";
./platforms/ios/Demo.xcodeproj/project.pbxproj:  PRODUCT_BUNDLE_IDENTIFIER = "com.app.demo";

If I remove the quotes and then run cordova plugin add, the quotes are added again. The search then returns the following result.

./platforms/ios/Demo.xcodeproj/project.pbxproj:  PRODUCT_BUNDLE_IDENTIFIER = "com.app.demo";
./platforms/ios/Demo.xcodeproj/project.pbxproj:  PRODUCT_BUNDLE_IDENTIFIER = "com.app.demo";
./platforms/ios/Demo.xcodeproj/project.pbxproj:  PRODUCT_BUNDLE_IDENTIFIER = "com.app.demo".WonderPushNotificationServiceExtension;
./platforms/ios/Demo.xcodeproj/project.pbxproj:  PRODUCT_BUNDLE_IDENTIFIER = "com.app.demo".WonderPushNotificationServiceExtension;

[ofavre]

I cannot reproduce the quotes.

Xcode accepts creating a project with a dash in it's bundle identifier and then uses quotes. Otherwise I have no quotes.
But since we're talking cordova I have to make cordova create the project and the cordova create command refuses dashes, underscores or accentuated characters.

Can you give me a reproduction with a few commands I would run?

[ofavre]

I've been fiddling a bit and managed to get Xcode to add quotes.
Can you test our plugin using the latest commit?

# Remove the plugin if necessary
cordova plugin rm wonderpush-cordova-sdk --variable CLIENT_ID=… --variable CLIENT_SECRET=…

# Checkout out the WonderPush Cordova SDK at the right commit
git clone https://github.com/wonderpush/wonderpush-cordova-sdk.git ../wonderpush-cordova-sdk
cd ../wonderpush-cordova-sdk
git checkout e03152cf950d4837ce3f31cce5c1982f134985af

# Go back to your project
cd -

# Add the WonderPush Cordova SDK from the local checkout
cordova plugin add ../wonderpush-cordova-sdk --variable CLIENT_ID=… --variable CLIENT_SECRET=…

Note the way to add the WonderPush Cordova SDK now uses a (relative) path.

If it works fine for you I'll release it.
I'm still interested in your reproduction commands if you can provide them.

[phillipplum]

Hey, I apologise for my delay.

Now I get this error:
/platforms/ios/WonderPushNotificationServiceExtension/wonderpushnotificationserviceextension-debug.xcconfig:7:1: error: could not find included file '../Pods/Target Support Files/Pods-WonderPushNotificationServiceExtension/Pods-WonderPushNotificationServiceExtension.debug.xcconfig' in search paths

If I create a new clean cordova project, the problem does not exist. So, I think I have a problem with other plugin(s). I will start with a new project and gradually add more plugins. Maybe I'll find the problem that way.

[phillipplum]

Hey I want to give a small update.

Your fix works but cordova-ios version >= 7 breaks Podfile on build. I create a issue for this: apache/cordova-ios#1389