Comments (4)
@jenndiaz Hey! I think I accidentally addressed this in PR #138. I meant for that PR to be limited to card styling, but I was playing around with some accessibility stuff on the same branch after I submitted the PR and didn't realize the subsequent commits would get pulled in (which there were several of because I also made and reverted a mistake). Ack, sorry for the confusion!
All I did was wrap the CardsDisplay component in a main tag in App.js. If I understand the issue correctly from my research, this is all we need, since we already have header and footer elements, which wrap all the other text and serve as banner and contentinfo landmarks. But if additional work is needed, happy to continue researching this. Thank you for the opportunity to learn about it!
from scrollodex.
@heretoshleigh can confirm adding the <main>
addresses this!!
but I think we could we get rid of the extra div now. This would clean up the code some and avoid using a non semantic tag.
<main>
<div>
<CardsDisplay />
</div>
</main>
I'll leave the issue open for now, if you take a look at it and can confirm it can be removed feel free to put up another PR removing it and link this issue.
from scrollodex.
@jenndiaz Thanks, Jenn! I took a look and see no problem with removing the extra div. Just submitted the PR.
from scrollodex.
from scrollodex.
Related Issues (20)
- Add .vscode directory to .gitignore HOT 3
- Address skipped heading level
- Address React Warning Invalid DOM property HOT 3
- Fix console react warnings HOT 1
- Add new designs for project buttons HOT 3
- Design input for footer component HOT 1
- start a contact form component HOT 6
- create a PR template :)
- add Scrollodex to Women Who Code OS site HOT 8
- Create a data model and database file for extensibility HOT 4
- Speed up image loading HOT 4
- make the card grid look better HOT 3
- Incorrect external linking on some cards HOT 3
- remove example card HOT 1
- Fix the extra card parastou rendering
- Add a 'dark-mode' to your card ( from issue #4)
- Address Contrast Failures in sort buttons HOT 1
- Add descriptive alt text to your headshot
- Align Scrollodex to new WWCode brand guidelines. HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scrollodex.