Did not work with multiple domains; here's a fix about nginx-certbot

[wmnnd]

Hey everyone, thank you for your patience!
The new 2.x branch now makes it much easier to specify multiple domains. You can now call the script like this to initialize it with multiple domains: ./init-letsencrypt.sh -d domain1.org -d domain2.org 🎉

[moritzschaefer]

do a PR <3

[bjornol]

Thanks for sharing this. Was looking to add the same. Worked like a charm

[dchersey]

The 2nd argument (production | staging) determines which docker-compose.$1 file is used later in the script. So that works if that's how you organize your docker-composes, otherwise the user has to modify accordingly. I'll create a PR shortly...

[wmnnd]

@dchersey I think it would be nicer to be more explicit here. So I suggest adding an -f parameter that allows specifying the actual docker-compose.yml path.

[romfrolov]

Well, it wasn't so flawless for me. For the first domain everything worked smoothly, but when it was running for the second one I got the following error:

Failed authorization procedure. <mydomain> (http-01): urn:ietf:params:acme:error:connection :: The server could not connect to the client to verify the domain :: Fetching http://<mydomain>/.well-known/acme-challenge/VaCGMLcnszmYVc6afGPJbGwUS2SjuKhWABLcCv2HZkM: Connection refused

[hodgef]

This worked for me. Thanks! I hope this is merged soon as the code on master is broken for multiple domains @wmnnd

[vesamet]

I don't think it will, since the maintainer doesn't seem to focus on this script for the last few months

EDIT: I guess I was wrong 🍂 :)

[wmnnd]

I like the idea of calling the script with the domains as parameters. That’s so much more elegant!

Instead of using staging and production as arguments, I would suggest a --staging switch, since productiondoesn't seem to do anything.

Feel free to create a PR for this 👍

[pablodiegoss]

I was just working with this and came to a really close solution, came here to check for any pending PRs or issues.
Nice dude, this will help a lot of people o/

[adespain]

I also like this solution! I apologize if you get an email for some domains I was testing @dchersey i forgot to change the address before I ran it. However with your updated script I am getting:

req: Can't open "/etc/letsencrypt/live/domain-example.com/privkey.pem" for writing, No such file or directory

for each of the domains, do you know why i get that error?

[vesamet]

@dchersey Same for me. I also got req: Can't open "/etc/letsencrypt/live/domain-example.com/privkey.pem" for writing, No such file or directory

[radusuciu]

Both the current and this modified init script just hang for me when getting dummy certs..

edit: solved by upgrading docker/docker-compose. not sure what the issue was but I recommend trying that for anyone else having a hanging issue.