Enabling support for showing window after process put to sleep (SDL2) about pdcurses

[bjadamson]

OK adding this for my own information,

when I re-open the app using "fg" from the command-line, I see the following backtrace:

#0  SDL_SetError_REAL (fmt=0x7ffff7f4b1c0 "Window surface is invalid, please call SDL_GetWindowSurface() to get a new surface") at /usr/src/debug/
SDL2-2.26.3-1.fc38.x86_64/src/SDL_error.c:32
#1  0x0000000000640e36 in PDC_update_rects () at /home/badamson/projects/rrogue/source/external/curses/sdl2/pdcdisp.c:66
#2  0x0000000000641f69 in PDC_doupdate () at /home/badamson/projects/rrogue/source/external/curses/sdl2/pdcdisp.c:561
#3  0x000000000063a9c0 in doupdate () at /home/badamson/projects/rrogue/source/external/curses/pdcurses/refresh.c:218
#4  0x000000000063aa89 in wrefresh (win=0x17a6d50) at /home/badamson/projects/rrogue/source/external/curses/pdcurses/refresh.c:242
#5  0x000000000062edab in platform::draw::update(CWinfo const&)::$_0::operator()() const (this=0x7fffffffa958) at /home/badamson/projects/rrogue/s
ource/platform/curses/common/draw.cxx:54
#6  0x000000000062ed7a in platform::draw::update(CWinfo const&) (window=...) at /home/badamson/projects/rrogue/source/platform/curses/common/draw.
cxx:54
#7  0x000000000060c728 in (anonymous namespace)::print_status(CWinfo const&, Player const&)::$_0::operator()() const (this=0x7fffffffaa48) at /hom
e/badamson/projects/rrogue/source/game/ui.cxx:109
#8  0x000000000060c538 in core::impl::DestroyFN<(anonymous namespace)::print_status(CWinfo const&, Player const&)::$_0&&>::~DestroyFN() (this=0x7f
ffffffaa40) at /home/badamson/projects/rrogue/source/core/macro/scope_exit.hpp:24
#9  0x000000000060ba70 in (anonymous namespace)::print_status(CWinfo const&, Player const&) (window=..., player=...) at /home/badamson/projects/rr
ogue/source/game/ui.cxx:137
#10 0x000000000060b81d in ui::render(MainWindows const&, Rogue&) (mainw=..., rogue=...) at /home/badamson/projects/rrogue/source/game/ui.cxx:199
#11 0x000000000060786d in (anonymous namespace)::draw_game(MainWindows&, Rogue&) (mainw=..., rogue=...) at /home/badamson/projects/rrogue/source/g
ame/turn.cxx:140
#12 0x0000000000606daf in (anonymous namespace)::command(CWindows&, Rogue&, CommandState&) (windows=..., rogue=..., cs=...) at /home/badamson/proj
ects/rrogue/source/game/turn.cxx:479
#13 0x0000000000606a1a in do_turn(CWindows&, Rogue&, CommandState&) (windows=..., rogue=..., cs=...) at /home/badamson/projects/rrogue/source/game
/turn.cxx:548
#14 0x000000000040bad5 in (anonymous namespace)::playit(CWindows&, Rogue&) (windows=..., rogue=...) at /home/badamson/projects/rrogue/source/game/
main.cxx:316
#15 0x000000000040b10a in main(int, char**) (argc=1, argv=0x7fffffffdeb8) at /home/badamson/projects/rrogue/source/game/main.cxx:504

Line's 0-4 are from inside pdcurses lib.

[bjadamson]

0  SDL_SetError_REAL (fmt=0x7ffff7f4b1c0 "Window surface is invalid, please call SDL_GetWindowSurface() to get a new surface") at /usr/src/debug/
SDL2-2.26.3-1.fc38.x86_64/src/SDL_error.c:32
#1  0x00007ffff7eac933 in SDL_UpdateWindowSurface_REAL (window=<optimized out>) at /usr/src/debug/SDL2-2.26.3-1.fc38.x86_64/src/video/SDL_video.c:
2756
#2  0x0000000000642329 in PDC_pump_and_peep () at /home/badamson/projects/rrogue/source/external/curses/sdl2/pdcdisp.c:591
#3  0x00000000006423bd in PDC_check_key () at /home/badamson/projects/rrogue/source/external/curses/sdl2/pdckbd.c:86
#4  0x0000000000637b07 in wgetch (win=0x1768440) at /home/badamson/projects/rrogue/source/external/curses/pdcurses/getch.c:378
#5  0x0000000000633b8e in platform::curses::backend::get_key(_win*) (window=0x1768440) at /home/badamson/projects/rrogue/source/platform/curses/pd
curses/pdcurses.cxx:207
#6  0x0000000000631f62 in (anonymous namespace)::get_key(CWinfo&) (window=...) at /home/badamson/projects/rrogue/source/platform/curses/common/key
board.cxx:41
#7  0x0000000000631f1d in platform::keyboard::readchar(CWinfo&) (window=...) at /home/badamson/projects/rrogue/source/platform/curses/common/keybo
ard.cxx:223
#8  0x0000000000519f64 in IOReader::read_key() const (this=0x7fffffffbe48) at /home/badamson/projects/rrogue/source/game/keyboard.cxx:102
#9  0x00000000006081e2 in (anonymous namespace)::get_command_user(IOReader const&, std::__debug::map<KeyCode, user::CID, std::less<KeyCode>, std::
allocator<std::pair<KeyCode const, user::CID> > > const&, ChatWindow&) (io_reader=..., cmd_table=std::__debug::map with 73 elements = {...}, chatw
=...) at /home/badamson/projects/rrogue/source/game/turn.cxx:371
#10 0x0000000000607a36 in (anonymous namespace)::command_next(Rogue&, CommandState&) (rogue=..., cs=...) at /home/badamson/projects/rrogue/source/
game/turn.cxx:417
#11 0x0000000000606e52 in (anonymous namespace)::command(CWindows&, Rogue&, CommandState&) (windows=..., rogue=..., cs=...) at /home/badamson/proj
ects/rrogue/source/game/turn.cxx:496
#12 0x0000000000606a1a in do_turn(CWindows&, Rogue&, CommandState&) (windows=..., rogue=..., cs=...) at /home/badamson/projects/rrogue/source/game
/turn.cxx:548
#13 0x000000000040bad5 in (anonymous namespace)::playit(CWindows&, Rogue&) (windows=..., rogue=...) at /home/badamson/projects/rrogue/source/game/
main.cxx:316
#14 0x000000000040b10a in main(int, char**) (argc=1, argv=0x7fffffffdeb8) at /home/badamson/projects/rrogue/source/game/main.cxx:504

[bjadamson]

I did some more digging ... it turns out this issue only happens when SDL_WINDOW_FULLSCREEN_DESKTOP is enabled during window creation. This is just a bug in my sdl version it seems.

[bjadamson]

Thanks for your help here. 👍