Comments (4)
Race condition #24 :D
from hibp.
The one thing you lose (I think) is the ability to do a
result.includes(searchString)
. You instead have to do anarray.filter(anonymousFunction)
like this. I would argue it follows principle of least surprise as you have to declare which field you want to search. Are there any other concerns I'm not thinking of?
I think filter
makes more sense than includes
. It's also more accurate as includes
would pick up substrings, perhaps unintentionally. It does come at a performance cost, though.
from hibp.
Even with filter()
, latency is still mainly spent on the http call. To be at the level where filter would matter CPU instructions wise, you'd be at pretty much at abuse level of the API.
from hibp.
Agreed, should be negligible.
from hibp.
Related Issues (20)
- Add API key support for paid endpoints (namely, `breachedaccount` and `pasteaccount`) HOT 1
- Update documentation for API v3 HOT 1
- Action Required: Fix Renovate Configuration
- CORS Error HOT 1
- Refactor pwnedPasswordRange to resolve with object? HOT 2
- All Contributors HOT 14
- Dependency Dashboard
- LogoType HOT 1
- Is there timeout on fetch? HOT 2
- Rate limiting `retry-after` HOT 2
- Error - "You may need an appropriate loader to handle this file type" HOT 5
- Not finding realy simple passwords HOT 3
- Forbidden - no user agent has been specified in the request. HOT 17
- Errors in web workers or extension background threads HOT 9
- TypeError: Cannot read properties of undefined (reading 'startsWith') HOT 4
- Request blocked or forbidden HOT 8
- Cannot use hibp modules in React Native development mode HOT 3
- Update rate limit handling HOT 1
- Invert `includeUnverified` option on `breachedaccount` endpoint HOT 1
- Invert `truncateResponse` option on `breachedaccount` endpoint HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hibp.