Coder Social home page Coder Social logo

Comments (4)

danieladams456 avatar danieladams456 commented on July 22, 2024 1

Race condition #24 :D

from hibp.

wKovacs64 avatar wKovacs64 commented on July 22, 2024

The one thing you lose (I think) is the ability to do a result.includes(searchString). You instead have to do an array.filter(anonymousFunction) like this. I would argue it follows principle of least surprise as you have to declare which field you want to search. Are there any other concerns I'm not thinking of?

I think filter makes more sense than includes. It's also more accurate as includes would pick up substrings, perhaps unintentionally. It does come at a performance cost, though.

from hibp.

danieladams456 avatar danieladams456 commented on July 22, 2024

Even with filter(), latency is still mainly spent on the http call. To be at the level where filter would matter CPU instructions wise, you'd be at pretty much at abuse level of the API.

from hibp.

wKovacs64 avatar wKovacs64 commented on July 22, 2024

Agreed, should be negligible.

from hibp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.