Coder Social home page Coder Social logo

SEO Improvements about gatsby-plugin-intl HOT 5 CLOSED

wiziple avatar wiziple commented on May 18, 2024
SEO Improvements

from gatsby-plugin-intl.

Comments (5)

olegshilov avatar olegshilov commented on May 18, 2024 2

You can get current language from pageContext and set lang attribute with react-helmet;
layout.js in gatsby-starter-default-intl might look like:

import React from "react";
import Helmet from "react-helmet";

export default ({
  children,
  pageContext: {
    intl: { language }
  }
}) => {
  return (
    <main>
      <Helmet htmlAttributes={{ lang: language }} />
      {children}
    </main>
  );
};

i'll create a pr right now

from gatsby-plugin-intl.

anicolaides avatar anicolaides commented on May 18, 2024

Looks like property intl of pageContext is undefined.

from gatsby-plugin-intl.

olegshilov avatar olegshilov commented on May 18, 2024

Looks like property intl of pageContext is undefined.

hm. i'll check this.

UPD:
@anicolaides really really sorry!
I didn't check that.

I my case i use gatsby-plugin-layout where pageContext available inside Layout component.
In this case, you ca take current locale value from intl prop, provided by injectIntl HOC, and put it inside SEO component lang prop on each page.

I create new PR #31 with fix now. You can check it.

from gatsby-plugin-intl.

anicolaides avatar anicolaides commented on May 18, 2024

@olegshilov No worries! Thanks so much for the PR and the insight!

from gatsby-plugin-intl.

anicolaides avatar anicolaides commented on May 18, 2024

I'm closing this one up!

Should #31 be merged, this problem will no longer exist.

from gatsby-plugin-intl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.