Coder Social home page Coder Social logo

Comments (18)

mcalero11 avatar mcalero11 commented on June 25, 2024 2

@emprecario I liked your approach and thank you for sharing it. However, in the end I used a different solution:

react-native-ui-lib+7.21.2.patch:

diff --git a/node_modules/react-native-ui-lib/src/assets/icons/[email protected] b/node_modules/react-native-ui-lib/src/assets/icons/[email protected]
deleted file mode 100644
index 902f55c..0000000
Binary files a/node_modules/react-native-ui-lib/src/assets/icons/[email protected] and /dev/null differ
diff --git a/node_modules/react-native-ui-lib/src/assets/icons/[email protected] b/node_modules/react-native-ui-lib/src/assets/icons/[email protected]
deleted file mode 100644
index 8346c27..0000000
Binary files a/node_modules/react-native-ui-lib/src/assets/icons/[email protected] and /dev/null differ
diff --git a/node_modules/react-native-ui-lib/src/assets/icons/[email protected] b/node_modules/react-native-ui-lib/src/assets/icons/[email protected]
deleted file mode 100644
index c43c034..0000000
Binary files a/node_modules/react-native-ui-lib/src/assets/icons/[email protected] and /dev/null differ
diff --git a/node_modules/react-native-ui-lib/src/assets/icons/[email protected] b/node_modules/react-native-ui-lib/src/assets/icons/[email protected]
deleted file mode 100644
index 5495134..0000000
Binary files a/node_modules/react-native-ui-lib/src/assets/icons/[email protected] and /dev/null differ
diff --git a/node_modules/react-native-ui-lib/src/assets/icons/[email protected] b/node_modules/react-native-ui-lib/src/assets/icons/[email protected]
deleted file mode 100644
index a1b0d0e..0000000
Binary files a/node_modules/react-native-ui-lib/src/assets/icons/[email protected] and /dev/null differ
diff --git a/node_modules/react-native-ui-lib/src/assets/icons/[email protected] b/node_modules/react-native-ui-lib/src/assets/icons/[email protected]
deleted file mode 100644
index 62ef8d1..0000000
Binary files a/node_modules/react-native-ui-lib/src/assets/icons/[email protected] and /dev/null differ
diff --git a/node_modules/react-native-ui-lib/src/assets/icons/[email protected] b/node_modules/react-native-ui-lib/src/assets/icons/[email protected]
deleted file mode 100644
index f9b22af..0000000
Binary files a/node_modules/react-native-ui-lib/src/assets/icons/[email protected] and /dev/null differ
diff --git a/node_modules/react-native-ui-lib/src/assets/icons/[email protected] b/node_modules/react-native-ui-lib/src/assets/icons/[email protected]
deleted file mode 100644
index 1288bb4..0000000
Binary files a/node_modules/react-native-ui-lib/src/assets/icons/[email protected] and /dev/null differ
diff --git a/node_modules/react-native-ui-lib/src/assets/icons/[email protected] b/node_modules/react-native-ui-lib/src/assets/icons/[email protected]
deleted file mode 100644
index ebc5f85..0000000
Binary files a/node_modules/react-native-ui-lib/src/assets/icons/[email protected] and /dev/null differ
diff --git a/node_modules/react-native-ui-lib/src/assets/icons/[email protected] b/node_modules/react-native-ui-lib/src/assets/icons/[email protected]
deleted file mode 100644
index 2dd5199..0000000
Binary files a/node_modules/react-native-ui-lib/src/assets/icons/[email protected] and /dev/null differ

Basically, I deleted all the assets with prefixes @4x and @1.5x
image

And now works
image

from react-native-ui-lib.

emprecario avatar emprecario commented on June 25, 2024 1
Captura de pantalla 2024-05-09 a las 18 50 43

from react-native-ui-lib.

bsalasA3 avatar bsalasA3 commented on June 25, 2024

Same here, but in Expo doesn't appear the button either

image

from react-native-ui-lib.

mcalero11 avatar mcalero11 commented on June 25, 2024

Same problem

  • "react-native-ui-lib": "^7.20.3"
  • "react-native": "0.73.6"
  • "expo": "^50.0.0"
  • "react-native-svg": "14.1.0"
  • "react-native-svg-transformer": "^1.3.0"

from react-native-ui-lib.

mcalero11 avatar mcalero11 commented on June 25, 2024

@JSantangelo-Octopus Were you able to find a solution to this?

from react-native-ui-lib.

emprecario avatar emprecario commented on June 25, 2024

Hi , @mcalero11 !! I modified the library component with patch-package to support a prop called renderHeader, and from my project I put icons with expo-icons. `diff --git a/node_modules/react-native-ui-lib/src/components/dateTimePicker/index.js b/node_modules/react-native-ui-lib/src/components/dateTimePicker/index.js
index 5518e3a..018638e 100644
--- a/node_modules/react-native-ui-lib/src/components/dateTimePicker/index.js
+++ b/node_modules/react-native-ui-lib/src/components/dateTimePicker/index.js
@@ -43,6 +43,7 @@ const DateTimePicker = forwardRef((props, ref) => {
headerStyle,
testID,
display = Constants.isIOS ? 'spinner' : undefined,

  • renderHeader: _renderHeader,
    ...others
    } = props;
    const [value, setValue] = useState(propsValue);
    @@ -118,6 +119,13 @@ const DateTimePicker = forwardRef((props, ref) => {
    }
    }, [onDonePressed, toggleExpandableOverlay]);
    const renderHeader = () => {

  • if (_renderHeader) {

  •  return _renderHeader({
    
  •    toggleExpandableOverlay,
    
  •    onDonePressed
    
  •  });
    
  • }

  • return <View row spread bg-$backgroundDefault paddingH-20 style={[styles.header, headerStyle]} testID={${testID}.header}>
    <Button link iconSource={Assets.icons.x} iconStyle={{
    tintColor: Colors.$iconDefault`

    ----> Component
    <DateTimePicker renderHeader={DatePickerHeader} themeVariant="light" renderInput={({value}) => ( <> <TextInput color={Colors.white} readonly value={value} trailingAccessory={dropdownIcon} placeholder="Fecha de concierto" /> </> )} {...field} />

from react-native-ui-lib.

mcalero11 avatar mcalero11 commented on June 25, 2024

@emprecario I will create the patch, I hope it works

from react-native-ui-lib.

emprecario avatar emprecario commented on June 25, 2024

@mcalero11 Here you have my DatePickerHeader component:

Captura de pantalla 2024-05-09 a las 19 06 16

from react-native-ui-lib.

JSantangelo-Octopus avatar JSantangelo-Octopus commented on June 25, 2024

@JSantangelo-Octopus Were you able to find a solution to this?

Hi! Nope, i was working in another project. I will try your patch, thanks!

from react-native-ui-lib.

janoslc avatar janoslc commented on June 25, 2024

Hi! I'm interested in this conversation, having the same issue.
@JSantangelo-Octopus did you apply any workaround which works for you?

from react-native-ui-lib.

janoslc avatar janoslc commented on June 25, 2024

So I used @mcalero11 's method and it's working. On my end it was enough to remove only these files:

Here's the patch source:

Filename: react-native-ui-lib+7.23.2.patch

diff --git a/node_modules/react-native-ui-lib/src/assets/icons/[email protected] b/node_modules/react-native-ui-lib/src/assets/icons/[email protected]
deleted file mode 100644
index 902f55c..0000000
Binary files a/node_modules/react-native-ui-lib/src/assets/icons/[email protected] and /dev/null differ
diff --git a/node_modules/react-native-ui-lib/src/assets/icons/[email protected] b/node_modules/react-native-ui-lib/src/assets/icons/[email protected]
deleted file mode 100644
index 8346c27..0000000
Binary files a/node_modules/react-native-ui-lib/src/assets/icons/[email protected] and /dev/null differ
diff --git a/node_modules/react-native-ui-lib/src/assets/icons/[email protected] b/node_modules/react-native-ui-lib/src/assets/icons/[email protected]
deleted file mode 100644
index c43c034..0000000
Binary files a/node_modules/react-native-ui-lib/src/assets/icons/[email protected] and /dev/null differ
diff --git a/node_modules/react-native-ui-lib/src/assets/icons/[email protected] b/node_modules/react-native-ui-lib/src/assets/icons/[email protected]
deleted file mode 100644
index 5495134..0000000
Binary files a/node_modules/react-native-ui-lib/src/assets/icons/[email protected] and /dev/null differ

"react-native-ui-lib": "^7.23.2"

from react-native-ui-lib.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.