Coder Social home page Coder Social logo

Comments (5)

pyronaur avatar pyronaur commented on August 17, 2024

I'll also appreciate any code feedback anyone might have, with things changing so quickly with Astro, I think some things may already be outdated. I haven't looked closer, but from the Astro announcement post, looks like I probably need to remove the custom Shiki setup?

from astro.build.

tony-sull avatar tony-sull commented on August 17, 2024

Nice! I really like the way you structured the code for loading post data, very clean 👍

As far as Shiki goes, the main difference in 0.25 is just that Shiki is now the default

{
    syntaxHighlight: 'shiki', // doesn't hurt anything, but this is no longer needed since Shiki is the default
    shikiConfig: {
	theme: 'poimandres',
	langs: [], // I'm not 100% sure, but I think you should add "astro" here to make sure Shiki is including `.astro` formatting
	wrap: false,
    },
}

from astro.build.

pyronaur avatar pyronaur commented on August 17, 2024

Thanks @tony-sull!

I cleaned up the config and it looks like "astro" isn't necessary in langs - tried it out here: https://simple-blog-template.netlify.app/testing/

from astro.build.

tony-sull avatar tony-sull commented on August 17, 2024

it looks like "astro" isn't necessary in langs

Learned something new! 😄 It's included in the config for one of our starter examples so I just assumed it was required, glad to see it's enabled by default in an Astro project 🚀

from astro.build.

pyronaur avatar pyronaur commented on August 17, 2024

🥳

just assumed it was required

I remember it not working for me a while back, so probably Shiki changed at some point.

from astro.build.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.