Comments (13)
These are great suggestions, thank you! I particularly like the suggestion of supporting a list of configurations of terms/locations pairs 👍 I think that's simple enough to explain and implement
The option commits is slightly unintuitive if it only refers to commit subjects
I had the same thought. I can’t think of a use case where I would look for a term in a commit body, but I agree that "commit_title"
is more clear than just "commit"
from app.
@gr2m, I like the configuration file location.
The configuration looks good, and easy to understand. This is added complexity, but have you considered allowing the application of different terms to each check location? Probably more bother than it's worth…
Regarding this issue's relation to #55, I take it I could then configure like this to replicate the behaviour I was interested in?
terms:
- fixup!
- squash!
check:
- commits
Thanks!
from app.
As an alternate name for check
, what do you think about locations
? Then both configuration options would be nouns, not a noun and a verb.
The option commits
is slightly unintuitive if it only refers to commit subjects. I don’t have a strong opinion between the following:
- changing the option to also search commit bodies
- renaming the option to something like
commit_subjects
- renaming the option, and also adding a
commit_bodies
option
My team’s workflow is to not allow merging if there’s a “hold” label, a “fixup!” or “squash!” commit, or “WIP” in the PR title or a commit. I’m not concerned about false positives for “fixup!”, “squash!”, or “WIP”, but I could see “hold” being used for unrelated reasons in commit titles. A potential syntax for configuration per check location could look like:
-
terms:
- hold
locations:
- label
-
terms:
- fixup!
- squash!
locations:
- commits
-
terms:
- WIP
locations:
- title
- commit
That is, each set of term/location pairs would be a list item.
from app.
I think for the usecase to block PRs if there are commits with "fixup!" or "squash!" it works good enough to add them to the terms
config. I don’t think there is a chance for false positives that these terms could be found in labels or the pull request title
from app.
Are there plans to also support .github/apps/wip.yml
.github/wip.yml
is the convention coming from Probot, I’ll stick to it
I've noticed configurations are only supported for Pro
Honestly if you need the configuration but can’t afford the $1/month (it will all be donated to https://railsgirlssummerofcode.org/) then I’m sure I can get you a voucher or something, don’t worry about it.
I like location more than checks but maybe it's a bit too vague. How about check_locations or verification_locations?
Thanks for your input! I think locations
is fine now, I’ll make sure to document it properly
from app.
Not yet, but once this PR gets merged and released, you can create a .github repository and out the default configuration file for your user or org in there: probot/probot-config#16 (comment)
What you can do today is reference other config files, see docs at https://github.com/probot/probot-config/
from app.
it’s now implemented as part of #94
You can see it working at wip/sandbox#3, configuration at https://github.com/wip/sandbox/blob/8377a438bfed66888c8ba7f72945c80bcaa55cb2/.github/wip.yml
from app.
The configuration will be done via a .github/wip.yml file
Are there plans to also support .github/apps/wip.yml
? Would be great to have a subfolder for apps so that GitHub configs are seperated.
from app.
- Pricing - Based on https://github.com/wip/app/blob/marketplace-app/HOW_IT_WORKS.md I've noticed configurations are only supported for Pro. Did you consider configuration to be supported for Free as well but only for PR title? This would allow users to still configure the terms without having full power. Not a requirement for me but just thinking out loud.
- Configuration Naming - I like
location
more thanchecks
but maybe it's a bit too vague. How aboutcheck_locations
orverification_locations
?
from app.
Configuration is here 🎉
I’ve pushed it to the beta version of the WIP app and would love all your help testing it, please see my update in the 🤖📯 Updates issue.
Thank you all for your patience and help 🙏
from app.
🎉 This issue has been resolved in version 3.1.0 🎉
The release is available on GitHub release
Your semantic-release bot 📦🚀
from app.
You can sign up for the pro plan on marketplace now to use the configuration feature https://github.com/marketplace/wip.
All revenue from the "pro" plan will be donated to Rails Girls Summer of Code. I only added the paid plan to make the WIP a real-life GitHub App example. If you cannot pay but depend on the pro features you can add your account with an explanation to the pro-plan-for-free.js
file.
from app.
Can WIP configuration defaults be changed for the whole organization, instead of on per-repo basis? If not, is it possible to implement?
from app.
Related Issues (20)
- An in-range update of probot is breaking the build 🚨 HOT 2
- The bot sent status about events from last year HOT 2
- WIP sending lots of very old “WIP checks stale” notifications HOT 2
- An in-range update of semantic-release is breaking the build 🚨 HOT 2
- How to address the issue of your GitHub App being down(just in case) HOT 2
- WIP blocks merging if commit message contains "wip" HOT 6
- Label matcher stopped working HOT 8
- Handle suspended installations
- Label matcher stopped working HOT 19
- M
- WIP Server seems to be hanging HOT 5
- Add support for the Draft prefix out-of-the-box HOT 1
- Title HOT 1
- wip/alp
- github/wip.yml is being ignored HOT 11
- Add support for merge_queue HOT 2
- Add support for :construction: `:construction:` (text) HOT 1
- The user data can't be public HOT 3
- Changing Title after Build kicks off makes WIP stuck HOT 2
- New to GitHub App HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from app.