Is there some number of data points that are too much for a line chart? I'm loading 6

mmm interesting, what version of the package are you running?<

🤔 <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="

If its helpful here is the data I am plotting: <div class="snippet-clipboard-conte

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

Linechart not plotting correctly with large number of points about swiftuicharts HOT 20 CLOSED

gesabo commented on August 30, 2024

Linechart not plotting correctly with large number of points

from swiftuicharts.

Comments (20)

willdale commented on August 30, 2024

mmm interesting,

what version of the package are you running?
What device?
Can you post some code?

struct LineChartDemoView: View {
    
    let data: LineChartData = weekOfData()
        
    var body: some View {
        
        LineChart(chartData: data)
            .id(data.id)
            .frame(minWidth: 150, maxWidth: 900, minHeight: 150, idealHeight: 500, maxHeight: 600, alignment: .center)
            .padding(.horizontal)
        
        .navigationTitle("Week of Data")
    }
    
    static func weekOfData() -> LineChartData {
        
        func makeDataSet() -> [LineChartDataPoint] {
            
            let datapoints: [LineChartDataPoint] = (1...600).map { index in
                if index < 240 {
                   return LineChartDataPoint(value: Double.random(in: 50...80))
                } else if index > 241 && index < 250 {
                    return LineChartDataPoint(value: Double.random(in: 90...100))
                } else if index > 251 && index < 290 {
                    return LineChartDataPoint(value: Double.random(in: 100...160))
                } else if index > 291 && index < 300 {
                    return LineChartDataPoint(value: Double.random(in: 160...180))
                } else if index > 301 && index < 350 {
                    return LineChartDataPoint(value: Double.random(in: 90...100))
                } else {
                    return LineChartDataPoint(value: Double.random(in: 60...80))
                }
            }
            return datapoints
        }
        
        let data = LineDataSet(dataPoints:
            makeDataSet(),
        legendTitle: "Steps",
        pointStyle: PointStyle(),
        style: LineStyle(lineColour: ColourStyle(colour: .red), lineType: .curvedLine, strokeStyle: Stroke(lineWidth: 1)))

        
        let chartStyle = LineChartStyle()
        
        return LineChartData(dataSets       : data,
                             metadata       : ChartMetadata(title: "Step Count", subtitle: "Over a Week"),
                             chartStyle     : chartStyle)
        
    }
}

Gives me:

Which looks right to me.

And with 2400 data points:

from swiftuicharts.

gesabo commented on August 30, 2024

🤔 @willdale I am running v 2.5.0 on iPhone 11 (iOS 14.5) I tried making sure your code was the same as mine but still seeing the different charts. Can't figure out what might be different between yours and mine?


struct CurrentCard: View {
    var body: some View {
      LineChart(chartData: data)
                         .id(data.id)
                         .yAxisLabels(chartData: data)
                         .frame(minWidth: 150, maxWidth: 900, minHeight: 150, idealHeight: 500, maxHeight: 600, alignment: .center)
                         //.frame(height: 180, alignment: .center)
                        .padding(.horizontal)
    }
    
    
        private func makeLineChartData(heartRates: [CustomHeartRateObject]) -> LineChartData? {

        let data = LineDataSet(
        dataPoints: heartRates.map { LineChartDataPoint(value: $0.doubleValue) },
        legendTitle: "Heart Rates",
        pointStyle: PointStyle(),
        style: LineStyle(lineColour: ColourStyle(colour: .red), lineType: .curvedLine, strokeStyle: Stroke(lineWidth: 1))
        )
        let chartStyle = LineChartStyle()
        

        
          return LineChartData(dataSets       : data,
                             metadata       : ChartMetadata(title: "Heart Rates", subtitle: "Today"),
                             chartStyle     : chartStyle)
                              
                            
    }

from swiftuicharts.

gesabo commented on August 30, 2024

If its helpful here is the data I am plotting:

from swiftuicharts.

willdale commented on August 30, 2024

This library currently only plots evenly spaced, this would mean if there is an area where there is more data, it will get spread out.

Could that explain it?

from swiftuicharts.

gesabo commented on August 30, 2024

@willdale yes that must be it then, heart rate data from the Apple watch is sampled sporadically (e.g. more frequent during a workout, less frequent during other times of day). 🤔

from swiftuicharts.

willdale commented on August 30, 2024

Is there a date component in CustomHeartRateObject, you could average to the hour, minute, second?

It would be good if the library could handle more time/date based rendering but I'm not sure when I'll get time to look at it.

from swiftuicharts.

gesabo commented on August 30, 2024

@willdale I tried interpolating a HR at every second of the day but that gives me over 56,000 values to chart so far today which I think might be too many as its crashing but I can't tell why.

from swiftuicharts.

willdale commented on August 30, 2024

A couple of Ideas:

To take inspiration from a Garmin app I use; to show a whole day they average to every two minutes - giving a maximum 720 data points for a day , then for workouts there is a separate chart that shows every second.

To take inspiration from Apple; to show a whole day they use a ranged bar chart showing the highest and lowest values in an hour. See Ranged Bar Chart in the ReadMe

from swiftuicharts.

gesabo commented on August 30, 2024

@willdale thanks for taking the time! I will give both a shot and see what works best. Thanks again for a great library. 🍻

from swiftuicharts.

kennedycraig commented on August 30, 2024

Hi, Will.
I actually am experiencing an issue like this again now that I upgraded to 2.5. The same issue is NOT appearing in 2.3 (I have 2.3 with the same data on a phone and 2.5 on a simulator. The x-axis is being spaced out again and the y axis has disappeared again...

from swiftuicharts.

willdale commented on August 30, 2024

I'm working on v2.6 which overhauls all the axes labels. Hopefully this will solve a myriad of problems!

@kennedycraig, Is that using xAxisLabelsFrom: dataPoint()?

from swiftuicharts.

kennedycraig commented on August 30, 2024

Hi, Will. No, its using .chartData(). Note that the xlabels bug only appears with a rotation modifier. Without the rotation modifier, I works as expected.

                                    xAxisLabelsFrom     : //.chartData(rotation: .degrees(90)),
                                        .chartData(),

from swiftuicharts.

willdale commented on August 30, 2024

Thanks, I'll work on a fix for an up and coming update.

from swiftuicharts.

willdale commented on August 30, 2024

Hopefully v2.6 has fixed this. 🙏

If not feel free to reopen this.

from swiftuicharts.

kennedycraig commented on August 30, 2024

For some reason 2.6 is not pulling in Xcode via swift package manager. No matter whether I reset the package cache and/or force update to latest version. Any ideas?

from swiftuicharts.

kennedycraig commented on August 30, 2024

For some reason 2.6 is not pulling in Xcode via swift package manager. No matter whether I reset the package cache and/or force update to latest version. Any ideas?

Just deleted the dependency and re-added - still get 2.5

from swiftuicharts.

willdale commented on August 30, 2024

@kennedycraig fixed in v2.6.1.

Odd issue with git not tracking .swiftpm folder.

from swiftuicharts.

gesabo commented on August 30, 2024

@willdale revisiting this, have you given any thought to adding support for time/date plotting as is discussed above? In other words correctly plotting a chart of heart rates even though the samples non equal gaps in between (resting HR every 5 minutes vs. workout HR every second).

from swiftuicharts.

willdale commented on August 30, 2024

@gesabo if you want to stick in a pull request, I'm more than happy to review it.

from swiftuicharts.

gesabo commented on August 30, 2024

@willdale I would love to if I had those chops 🤣 but I'm not even sure where to start.

from swiftuicharts.

Linechart not plotting correctly with large number of points about swiftuicharts HOT 20 CLOSED

Comments (20)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent