Comments (3)
This is a duplicate of #202. That issue also contains a suggested alternative implementation by Teun van den Brand that I think is the right way forward. If you want to prepare a PR based on that you're welcome to do so.
from cowplot.
@clauswilke my apologies, I should have checked to see if someone else had already commented on the error.
From the discussion, it seems like the fix in #202 allows the user to pass along the expected location which is also reasonable.
It still might be worthwhile to consider filtering out the zeroGrubs from get_plot_component
when the user only expects one return, at least then the return object will always contain a non-zero grub if the expected behavior is to return a zeroGrub if all are zero, then you could modify my proposed solution #206 to account for that.
Either way, thank you for this package, it's handy, just trying to see if I could help contribute and make it better! :)
from cowplot.
That's fine, you're welcome to merge your ideas and Teun's ideas in your PR. I haven't thought about this function much recently but I agree it should be fixed.
from cowplot.
Related Issues (20)
- Cannot convert object of class LayerInstanceLayerggprotogg into a grob?
- changing size of the second plot in plot_grid() HOT 2
- ggarange common.legend positioning overwritten
- No side effect from plot_grid when used inside a function returning an object
- get_legend doesn't match original position
- Blank plot using plot_grid with RNotebook
- Feature request: options for anchors of labels in plot_grid HOT 1
- warning message: The `size` argument of `element_line()` is deprecated as of ggplot2 3.4.0. HOT 5
- Explanation of how align_plot, ggdraw, and draw_plot work together for dual-y-axis plots.
- `draw_image` only works when background themes are set to `ggplot2::element_blank()` HOT 1
- Aligning legends?
- plot_grid not working HOT 1
- Cowplot breaks dates? HOT 2
- Cowplot() plot_grid() squishing axes and legend
- Mix bold and plain text in `cowplot::draw_label`
- Labels in `plot_grid()` seemed not affected by `byrow` HOT 2
- Is geom_image (ggimage) not working anymore with Kaggle? HOT 1
- Shared legend feature stopped workin with ggplot2 v3.5.0 HOT 10
- Calling save_plot( ) non-interactively via Rscript creates empty Rplots.pdf file
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cowplot.