Comments (15)
HAHAHAHA.
Sorry but no!
Back in 2004 I did this change: 93c94bc
And that broke compatibility with upstream in a big way.
Upstream had the following problems:
- All parsing was done with fixed length buffers and no bound checking (buffer overflows everywhere.)
- Not threaded/threadable at all.
from wifidog-gateway.
Just for information: Nodogsplash seems used 1.4.
nodogsplash/nodogsplash@f19ef42
from wifidog-gateway.
Ah, so someone went through the trouble of reapplying the wifidog patches to upstream. I'm not sure of the benefit... But we could merge their update in.
from wifidog-gateway.
In fact, switching to the nodogsplash version of libhttps would be good, they fixed things we missed...
nodogsplash/nodogsplash@f2b83e2
After more checking, I think it's a fairly big project to merge nodogsplash' libhttpd and then cherry pick all the patches only on wifidog's libhttpd. What's the benefit of 1.4 vs. 1.3? The change log doesn't really bring anything to the table.
from wifidog-gateway.
This is the diff between upstream 1.3 and upstream 1.4 (excluding configure
):
https://gist.github.com/acv/22ff3b4a64c8b10dc938
Most of the new code needs refactoring to deal with the thread split. The Ember support is another lib from Hughes to embed a tiny scripting language.
from wifidog-gateway.
I think the easiest way forward is to pick from the diff and integrate what makes sense from it and then bump the version. Also go on a fishing expedition in the nodogsplash repo and cherry pick more fixes.
from wifidog-gateway.
So, should we bring in the Text Expansion and Ember support from libhttpd 1.4? Both features seem to be geared to using Ember which is Hughes' embedded web scripting language (which only works with libhttpd and mSQL...)
I haven't in my PR #91
from wifidog-gateway.
No. I have only 4MB flash. :)
from wifidog-gateway.
Cool, then it's pretty complete.
from wifidog-gateway.
Then let's merge? I haven't tested it, but I assume you did ;)
from wifidog-gateway.
Somewhat ;-).
from wifidog-gateway.
I'm not nearly as bad as in the early days where if gcc didn't complain, I commited ;-)
from wifidog-gateway.
Groovy! I would have merged via github, but it can't be merged automatically. :(
from wifidog-gateway.
Merged master back into it. I hope I didn't accidentally remove any code.
from wifidog-gateway.
Fixed in#91.
from wifidog-gateway.
Related Issues (20)
- wifidog iptablesV1.4.10 REDIRECT does not work HOT 3
- Wifidog don't block traffic HOT 4
- Reload wifidog HOT 2
- WifiDog send me error
- List and clear client
- wifidog: could not create web server : addess already in use HOT 2
- getting error: (gateway.c:377) Could not get IP address information of br-lan HOT 2
- Explicitly killing the fw_counter thread,
- When I started Wifidog,I found iptables command execute failed HOT 1
- How to setup wifidog captive portal?
- Wifidog Internet not block openwrt 19.07.5 last version
- Wifi asu
- Html
- My phones
- installation password
- New rfc for captive portal identification
- No suporte a new iptables version syntax iptables v1.8.7 (legacy) HOT 2
- wifidog: could not create web server : addess already in use #300 HOT 1
- Wifidog error iptables_fw_counters_update(): Could not find 0 in client list HOT 8
- All device gets disconnected after the second device connects to the network
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wifidog-gateway.