Resync libhttpd about wifidog-gateway

[acv]

HAHAHAHA.

Sorry but no!

Back in 2004 I did this change: 93c94bc

And that broke compatibility with upstream in a big way.

Upstream had the following problems:

1. All parsing was done with fixed length buffers and no bound checking (buffer overflows everywhere.)
2. Not threaded/threadable at all.

[florida63]

Just for information: Nodogsplash seems used 1.4.
nodogsplash/nodogsplash@f19ef42

[acv]

Ah, so someone went through the trouble of reapplying the wifidog patches to upstream. I'm not sure of the benefit... But we could merge their update in.

[acv]

In fact, switching to the nodogsplash version of libhttps would be good, they fixed things we missed...

nodogsplash/nodogsplash@f2b83e2

After more checking, I think it's a fairly big project to merge nodogsplash' libhttpd and then cherry pick all the patches only on wifidog's libhttpd. What's the benefit of 1.4 vs. 1.3? The change log doesn't really bring anything to the table.

[acv]

This is the diff between upstream 1.3 and upstream 1.4 (excluding configure):

https://gist.github.com/acv/22ff3b4a64c8b10dc938

Most of the new code needs refactoring to deal with the thread split. The Ember support is another lib from Hughes to embed a tiny scripting language.

[acv]

I think the easiest way forward is to pick from the diff and integrate what makes sense from it and then bump the version. Also go on a fishing expedition in the nodogsplash repo and cherry pick more fixes.

[acv]

So, should we bring in the Text Expansion and Ember support from libhttpd 1.4? Both features seem to be geared to using Ember which is Hughes' embedded web scripting language (which only works with libhttpd and mSQL...)

I haven't in my PR #91

[mhaas]

No. I have only 4MB flash. :)

[acv]

Cool, then it's pretty complete.

[mhaas]

Then let's merge? I haven't tested it, but I assume you did ;)

[acv]

Somewhat ;-).

[acv]

I'm not nearly as bad as in the early days where if gcc didn't complain, I commited ;-)

[mhaas]

Groovy! I would have merged via github, but it can't be merged automatically. :(

[acv]

Merged master back into it. I hope I didn't accidentally remove any code.

[mhaas]

Fixed in#91.