Coder Social home page Coder Social logo

Comments (10)

annevk avatar annevk commented on May 12, 2024 1

Please don't conflate Clear-Site-Data with "Clear cookies" UI. The latter has to take all kinds of things into consideration and doesn't have much relation to "cookies". The keying is also very different.

From the other discussion it seems like "cache" might be the way to go.

from compression-dictionary-transport.

yoavweiss avatar yoavweiss commented on May 12, 2024

Should "dictionaries" be separate from "cache" here?

I'd also assume that when users delete their cache (regardless of ClearSiteData), dictionaries will go away.

from compression-dictionary-transport.

horo-t avatar horo-t commented on May 12, 2024

On second thought, I feel like clearing the dictionaries for Clear-Site-Data: "cache" may be enough.
@pmeenan Do you have any thought about it?

I'd also assume that when users delete their cache (regardless of ClearSiteData), dictionaries will go away.

Yes, dictionaries should be deleted when the user clears the cache or cookies from the browser's settings page.

from compression-dictionary-transport.

pmeenan avatar pmeenan commented on May 12, 2024

I don't think we need a new entry specifically. The dictionaries should be cleared when either the cache or cookies are cleared. Actual implementation may be a bit more complex, but I find it easiest to think about the dictionary information as metadata about cache entries. If the cache entries go away then the dictionary is also gone.

The metadata has cookie-like concerns so it needs to also be cleared when cookies are cleared.

The argument could be made that it only needs to be cleared from clear-site-data when cache is cleared but if a user triggers UI to clear cookies then it also needs to be cleared but it feels like it would be cleaner to just always nuke the dictionaries when either the underlying HTTP cache gets cleared or user state is cleared.

from compression-dictionary-transport.

pmeenan avatar pmeenan commented on May 12, 2024

sgtm. It's much cleaner to describe that way too. I'll add some text to cover that case.

from compression-dictionary-transport.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.