Coder Social home page Coder Social logo

Comments (6)

arichiv avatar arichiv commented on May 14, 2024

@abeyad @miketaylr

from client-hints-infrastructure.

abeyad avatar abeyad commented on May 14, 2024

As a side note, I think Critical-CH-Restart should be a boolean; I don't think a count doesn't make sense since Critical-CH should only result in up to one resend of the request.

from client-hints-infrastructure.

amtunlimited avatar amtunlimited commented on May 14, 2024

@davidben since you own the spec (in a way), any thoughts?

@abeyad that's actually not quite true anymore. The Critical-CH restarts are now counted as part of the navigation redirect limit, so there could be a number of times.

That being said, there's a question of if the header should persist through a redirect chain, or just on the one "restarted" request. I was leaning towards just a boolean and not passed to the next redirect

from client-hints-infrastructure.

davidben avatar davidben commented on May 14, 2024

better handling of still-missing headers

What kind of better handling were you envisioning? The server is equally obligated to respond to the missing headers in both requests. On the first request, if you send Critical-CH, the client may well choose not to restart, in which case the response is used as-is.

from client-hints-infrastructure.

amtunlimited avatar amtunlimited commented on May 14, 2024

I suppose I was envisioning a server seeing that header and gracefully handling, vs not seeing it and assuming it will be dropped, but that's probably not a good precedent to set

from client-hints-infrastructure.

davidben avatar davidben commented on May 14, 2024

Yeah, such a server would break if the client doesn't support the hint, or declined to send it for some reason.

from client-hints-infrastructure.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.