Unable to provide a DockerFactory for 0.9.0-RC3 about docker-it-scala

[akauppi]

Got it solved, and the project is here: https://github.com/akauppi/etcd3-bench

• Add to libraryDependencies:

    "com.whisk" %% "docker-testkit-impl-docker-java" % "0.9.0-RC3" % Test

• Mix DockerKitDockerJava into the test:

class SomeTest extends FlatSpec with Matchers with DockerEtcdV3Service with DockerTestKit with DockerKitDockerJava {

I'd leave editing the README to the maintainers - I'm sure this will be handled once 0.9.0 becomes a true release. It would also be nice to have a short comparison there to see the pros/cons of using either DockerKitDockerJava vs. DockerKitSpotify. Thanks.

Using docker-it-scala is again as easy as it was! :)

[mdotson]

I think that there's two main java implementations of a docker client: spotify docker and docker java. I actually just realized this after reading through this PR. I have no idea of the pros and cons though. The spotify one's README is much clearer and approachable.

Luckily the tests have good examples to take from.

[akauppi]

Yep, they are available as different artifacts that the customer project now explicitly needs to bring in. e.g.

"com.whisk" %% "docker-testkit-impl-docker-java" % ver

The samples in docker-it-scala seem to be more using the Spotify version.

What I'd like to see is a brief instruction for end users on the pros/cons of the two. Also, DockerTestKit could use a self-class to highlight in compilation that it wants either of those classes to be brought in. Before 0.9.0, I think DockerTestKit stood by itself. This, of course, would mean that DockerKitDockerJava and the Spotify version would need to derive from a common tag trait.

[viktortnk]

I'm closing it now as there were few releases since and tests provide good idea on how to override a factory