Comments (6)
No, I think we should amend step 27 to also run its substeps when temporaryBody is non-null, agreed?
(How do you want to be acknowledged? See https://fetch.spec.whatwg.org/#acknowledgments for options, but anything goes.)
from fetch.
Looks good.
Please write as "平野裕 (Yutaka Hirano)". Thanks!
from fetch.
Oh, I didn't notice extracting init's body doesn't work when it's null (and temporaryBody is non-null). How about the following?
(27) If init's body member is present:
- Let stream and Content-Type be the result of extracting init's body member.
- Set temporaryBody to stream.
- If Content-Type is non-null and r's request's header list contains no header named
Content-Type
, appendContent-Type
/Content-Type to r's Headers object. Rethrow any exception.
(28) If temporaryBody is non-null and request's method is GET
or HEAD
, throw a TypeError.
from fetch.
Good point. However, to avoid impacting any passed in readable streams, I opted for reversing those two steps and adding a conditional to your step 28.
from fetch.
(The idea is to make failure as side effect free as it can be.)
from fetch.
Nice catch! Gecko bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1154268
from fetch.
Related Issues (20)
- RequestInit::priority lacks corresponding Request::priority attribute
- Referrer determination should be done on updated URLs in main fetch
- Automatic decompression should sanitize `Content-Encoding` and `Content-Length` headers from the response HOT 1
- When there is an issue with the URL parameter, fetch does not have any errors
- add a method to get a Uint8Array to Body HOT 4
- Fetch with Flask or Microdot HOT 1
- Service worker "handle fetch" seems to assume it's called in parallel HOT 2
- Redirect loop handling not discussed
- Add compression dictionary negotiation and decoding to the fetch processing model HOT 2
- Reconsider default Accept values for images
- Fetch support for explicit resource management
- Consider renaming or replacing http3only? HOT 1
- [render-blocking] The links of "render-blocking" in fetch are vague HOT 2
- Define what consequences NULL bytes (0x00) or other invalid values in header names have HOT 1
- 0x00 byte (%00) in a data: URL
- fetch does not allow caching requests with a null client HOT 1
- Question about stream handling around fetch requests with integrity metadata HOT 3
- Allow `new Response` with 101 status code HOT 6
- Question regarding preflight requests using the original request destination HOT 1
- Expected behavior of Response.redirect(null)? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fetch.