GBK encoding/decoding support about encoding

[annevk]

The href failures are somewhat expected. Firefox doesn't use the same strategy as <form> there yet.

We should probably investigate the smaller number of failures from Chrome/Safari/Edge in encode/decode.

[r12a]

List of bugs raised:

• https://bugs.webkit.org/show_bug.cgi?id=159892
• https://bugzilla.mozilla.org/show_bug.cgi?id=1285400
• https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/8202282/
• https://bugs.chromium.org/p/chromium/issues/detail?id=626406

[jungshik]

Chromium's failure is expected. See http://crbug.com/339862 and http://crbug.com/430823

[annevk]

@r12a this is the first in a series of issues you raised about tests. I'm not sure how I can address these from a standards-perspective. What would it take to get them closed?

[r12a]

yeah, these are a little unusual. I'm not sure (other than of course all implementations passing all tests).

We raised them here so that (a) they would be noticed, and so we had something to point to where people could hold a discussion if they wanted, although actually much of the discussion is taking place in the browser bugs raised, but also (b) so that we had a central location pointing to and perhaps from time to time summarising the implementation work/issues, so that people are notified of movement without having to subscribe to all the many bugs raised. (For example, i've been meaning to point to https://bugs.webkit.org/show_bug.cgi?id=159891, which seems to need suggestions on how to move forward.)

if you feel you want to close them we could do so, but perhaps we could add a comment saying that people can still contribute to the discussion while closed(?)

[annevk]

I guess I'll leave them all open for now then. Not in a rush.

[hsivonen]

AFAICT, the gbk tests differ from the spec for one code point to byte pair and vice versa mapping:
The tests want A8 BC to decode to U+E7C7 and want U+E7C7 to encode to A8 BC. However, per spec, A8 BC maps to U+1E3F.

[hsivonen]

Additionally, the tests seem to disargee with the spec on the handling of ASCII bytes as part of a malformed sequence when decoding:
Fail step 2: 82 30 C3 assert_equals: expected "�" but got "�0�"
Fail step 5.7: 82 FF C3 33 assert_equals: expected "��" but got "��3"
Fail step 9: FF 30 C3 33 assert_equals: expected "�0�" but got "�0�3"

[vyv03354]

Firefox Nightly 56 improved the encoder, but it still has one test failure. Apparently the decoder has no improvement.

[r12a]

Today and yesterday i updated the results at https://www.w3.org/International/tests/repo/results/encoding-dbl-byte.en#gbk for Firefox, FNightly, Chrome, and Canary. The latest summary is:

(There are columns for nightlies only where the results differ from the released versions.)

[r12a]

Firefox's one failure is this:

U+E7C7  %A8%BC assert_equals: expected "%A8%BC" but got "%26%23%35%39%33%33%35%3B"

could be an issue with the test(?)

[hsivonen]

Firefox's one failure is this:

U+E7C7  %A8%BC assert_equals: expected "%A8%BC" but got "%26%23%35%39%33%33%35%3B"

could be an issue with the test(?)

That's indeed a test bug. See upthread.

[annevk]

Upstreaming these tests never completed. There's web-platform-tests/wpt#20360 but it needs work.