Coder Social home page Coder Social logo

Comments (6)

hatcat avatar hatcat commented on July 17, 2024

I'm conflicted about adding API that would defeat the FIFO nature of the ring. I can see how they are "missing" from the interface when other containers are taken in to account, but the point of the ring is that you put something in to it, and then you take it out again, in order. The addition of these functions makes the interface easier to use incorrectly. Do you have some use cases for interfering with a ring in this way?

from sg14.

martinmoene avatar martinmoene commented on July 17, 2024

I'm conflicted about adding API that would defeat the FIFO nature of the ring.

The word 'ring' inherently does not convey any meaning with respect to a beginning or an ending.

Has the name fifo_span ever been considered?

from sg14.

martinmoene avatar martinmoene commented on July 17, 2024

So then, among others, there are the forces of symmetry/asymmetry and easy to use/hard to misuse.

from sg14.

Quuxplusone avatar Quuxplusone commented on July 17, 2024

My opinion is that we ought to provide them since they're cheap. (I can't think of anything that would make them expensive for any implementation to provide.) I'll note that our ring<T>::iterators right now are BidirectionalIterators, not ForwardIterators, which implies that people ought to be able to iterate in reverse (#100, #107), which is related to this issue — this issue is about not merely "traversing backwards", but actually "mutating backwards".

I do wonder whether something special ought to happen if you try to push_front onto a ring that is already full. Should it really overwrite the back element of the ring and decrement the end pointer? This does feel somehow awkward; but it is perfectly symmetrical with push_back.

from sg14.

mattreecebentley avatar mattreecebentley commented on July 17, 2024

I don't really have a lot of input here, as inexperienced as I am with ring buffers, but the only thing I'd note is whatever behaviour is added should ideally follow the principle of least surprise, for end-user. M

from sg14.

hatcat avatar hatcat commented on July 17, 2024

I'm not sure that cheap is a good enough reason to trump increased possibility of misuse, but perhaps we can let the committee decide.

from sg14.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.