Coder Social home page Coder Social logo

Comments (5)

greenlucid avatar greenlucid commented on July 23, 2024

Isn't this intended? uint is a solidity alias, is it ABI conforming?

from abitype.

krzkaczor avatar krzkaczor commented on July 23, 2024

@greenlucid you are right that EIP-712 doesn't support uint alias (i copied the whole selector from the sourcecode -- that's why i hit that).

However, I think that there should be some kind of error instead of a silent failure.

from abitype.

tmm avatar tmm commented on July 23, 2024

Thanks for reporting! Think we already have some code in PR that will solve this.

from abitype.

Raiden1411 avatar Raiden1411 commented on July 23, 2024

@tmm not sure if the current PRs have a fix for this. Unless I am missing something on your side.

If you don't have anything I can work on a PR that fix this.

from abitype.

tmm avatar tmm commented on July 23, 2024

Based on my interpretation of this (also below):

uint, int: synonyms for uint256, int256 respectively. For computing the function selector, uint256 and int256 have to be used.

"type": "uint" and "type": "int" are both allowed. Not sure if any compilers output these as-is or convert to the fixed versions. Either way, converting things in #110


Separately, uint and int are already not allowed in EIP-712 Typed Data (see TypedDataType).

from abitype.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.