Coder Social home page Coder Social logo

Comments (6)

weppos avatar weppos commented on June 2, 2024

Actually, you can do it in the following way

PublicSuffixService::Rulelist.default << PublicSuffixService::Rule.factory("*.test")

Does it sounds good enough for you? It's not very concise, I know, but until today I didn't met frequent cases where you should add new rules instead of relying on the default ruleset.

from publicsuffix-ruby.

jamesbebbington avatar jamesbebbington commented on June 2, 2024

Yup that works for me, thanks weppos!

from publicsuffix-ruby.

jamesbebbington avatar jamesbebbington commented on June 2, 2024

Actually, that doesn't seem to work for me:

> PublicSuffixService.valid?("foo.com")
true
> PublicSuffixService.valid?("foo.test")
false
> PublicSuffixService::RuleList.default << PublicSuffixService::Rule.factory("*.test")
> PublicSuffixService.valid?("foo.test")
false

from publicsuffix-ruby.

weppos avatar weppos commented on June 2, 2024

The rule should be

PublicSuffixService::Rule.factory("test")

The wildcard allows something.domain.test but not domain.test. However, there's indeed a bug. When a new rule is added to the list, the cache is not recreated.

To temporary fix the issue use

PublicSuffixService::RuleList.default.create_index!

after you appended the rule. I'm going to work on a patch today.

from publicsuffix-ruby.

jamesbebbington avatar jamesbebbington commented on June 2, 2024

Ah, that did the job, thanks weppos.

from publicsuffix-ruby.

weppos avatar weppos commented on June 2, 2024

Closed by 0ac5599

from publicsuffix-ruby.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.