Comments (3)
Hi Ben,
I thought a little bit before answering, but I still don't have a definitive answer. Parsing email is a little bit beyond the scope of this library. I've been trying to keep this library as focused as possible on the PSL.
People asked me to add URI validation, email validations, etc, but they are hard businesses and I'm not sure they fit well into this library. For example, addressable should be used if someone wants to parse an URI, instead of a domain.
That said, I would suggest you to provide a patch. If the patch is good enough to be simple, clean and maintainable, I'll keep it into consideration. :)
from publicsuffix-ruby.
I can respect that. Do one thing, do it well. I can't even imagine the number of edge cases and don't want to be the one to maintain it. Pushing the logic to the edge is a better solution. Closing here.
Two follow ups:
- If relying on PublicSuffix for validation, would you recommend putting something like Addressable in front of it to properly parse the input string?
- Do you know of anything like addressable for email addresses? Doesn't look like addressable supports 'em.
Edit: email veracity looks like it's a much better approach than my regex.
from publicsuffix-ruby.
@weppos took a pass at this over in benbalter/gman#21. Thanks for the insight. Since it's relying on outside gems, may be able to pull the get_domain
method in here if there's interest.
from publicsuffix-ruby.
Related Issues (20)
- need help understanding PublicSuffix::DomainNotAllowed HOT 1
- Causes errors in Logstash HOT 2
- Parse herokuapp.com domain HOT 2
- Documentation issue: wrong return type of PublicSuffix::List.parse HOT 1
- Validation issue in PublicSuffix HOT 1
- Domain validation missing HOT 1
- Can PublicSuffix::List impliment enumerable? HOT 3
- Unnecessary files bundled within gem HOT 3
- Document domain?, subdomain? et all in README.md HOT 1
- Ruby 2.3 requirement HOT 7
- `elb.amazonaws.com` is not allowed according to Registry policy HOT 1
- Ruby 2.7 warning about PublicSuffix::List.default HOT 7
- yardoc rake task fails with `NameError: uninitialized constant YARD::CLI`
- Possible error installing when path contains a space HOT 1
- this gem should not be used for validating domain names HOT 3
- Similar list than publicsuffix, but for path HOT 1
- Error while parsing few domains HOT 3
- Cut new release of Gem HOT 2
- ERROR: some domains are not allowed according to Registry policy HOT 4
- New release after every list update HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from publicsuffix-ruby.