Coder Social home page Coder Social logo

Comments (4)

vzaidman avatar vzaidman commented on May 21, 2024

fixing

from why-did-you-render.

vzaidman avatar vzaidman commented on May 21, 2024

fixed in 3.3.8:
https://codesandbox.io/s/welldone-softwarewhy-did-you-render-memo-a-text-example-pzn3b

from why-did-you-render.

JackHowa avatar JackHowa commented on May 21, 2024

I'm still seeing this using a custom memo check

import React, { memo } from 'react';
import PropTypes from 'prop-types';
import { StyledContainer } from './styles';
import deepCompareUpdate from '~/utils/deepCompareUpdate';

function Item({ things, title }) {
  return (
    <StyledContainer>
      <div>
        <h5>{title}</h5>
        {things.map(thing => (
          <p key={thing}>{thing}</p>
        ))}
      </div>
    </StyledContainer>
  );
}

Item.propTypes = {
  title: PropTypes.string,
  things: PropTypes.array,
};

Item.defaultProps = {
  title: '',
  things: [],
};

export default memo(Item, deepCompareUpdate);


// deepCompareUpdate
import isEqual from 'react-fast-compare';
// fast compare is like lodash's isEqual but suited for react
// note: neither solve for checking children components
// https://formidable.com/blog/2018/introducing-react-fast-compare/

const deepCompareUpdate = (props, nextProps) =>
  Object.keys(props).some(k => !isEqual(props[k], nextProps[k]));

export default deepCompareUpdate;

Screen Shot 2019-12-19 at 11 10 25 AM

**some code removed if you see props in the warning, unrelated to issue

from why-did-you-render.

vzaidman avatar vzaidman commented on May 21, 2024

@JackHowa where's the problem?
do you have

TypeError: e.apply is not a function

?

from why-did-you-render.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.