[Question] ability to add to all components? about why-did-you-render

[justinhelmer]

Thanks for the quick reply. I suppose I'm suggesting something along these lines:

return !!(
  options.includeAll ||
  Component.whyDidYouRender ||
  shouldInclude(displayName, options)
)

[vzaidman]

what would you like to use to decide if a component should be tracked?

https://github.com/welldone-software/why-did-you-render/blob/master/src/shouldTrack.js

here is the file that makes this decision

[vzaidman]

try include: [/.*/].

what do you say?

[justinhelmer]

works like a charm, thanks.

Closing

[zhangenming]

so why not provide a option?
such as

const whyDidYouRender = require('@welldone-software/why-did-you-render')
whyDidYouRender.isTrackAllPureComponent = true //default can be false
whyDidYouRender(React)

[vzaidman]

i don't want people to track all components. it's not a best practice.
if you want to do it, use include: [/.*/]

[zhangenming]

i don't want people to track all components. it's not a best practice.
if you want to do it, use include: [/.*/]

i dont very familiar about react
how about just track all component that implement SCU (or PureComponent )
thanks

[vzaidman]

that's a good idea. ill consider it

[vzaidman]

implement SCU?

[zhangenming]

scu: shouldComponentUpdate

[vzaidman]

ok ill add this configuration. thanks for the idea