Comments (13)
I think that despite I'm really used to not have the extension, I'm totally with you. So if any follower of this conversation would not have something to argue, I'll choose to accept your reasons and implementations
from wordmove.
Mmm...I think this was just a sort of borrow from Gemfile , Rakefile and families. I'm quite agnostic about the topic, so I'll let other maintainers drop some words on it.
Meanwhile: have you ever seen this ST package?
from wordmove.
I've added some code that should implement this, you should be able to use seamlessly Movefile
, Movefile.yml
or Movefile.yaml
Basically what @pioneerskies is correct: the Movefile is another child of the family of Makefile, Gemfile, Cakefile, Rakefile, which are all generally used without extensions.
This will get published in a new version before the end of the week, let me know if there are issues|
from wordmove.
Hi,
Thank you for accepting and applying this change so fast.
@pioneerskies : I've added the ApplySyntax package to my ST and created my own rule to allow syntax highlighting on Movefile. Thanks.
from wordmove.
@nlemoine you're welcome and we're glad of your contribuition
from wordmove.
@pioneerskies Any chance you may mention in the docs that Movefile can also take the yaml
or yml
?
from wordmove.
I could say yes, but I'd be happy to see a wiki contribution or a pull request against the README 💃
If you can't it'd be probably better to open a new issue in order to keep it in mind
from wordmove.
No problem, I just wanted to ask before submitting a PR 😉
Just in case, I'm taking a chance to go further, would you consider default Movefile
to become a Movefile.yml
file (e.g. file created with wordmove init
)?
As you explained earlier in this ticket, I know you borrowed this file name from some Ruby world convention (Gemfile, Rakefile, etc.) but:
- those files are
ruby
, notyaml
- those files come from widespread and well known libraries and are therefore recognized by most editors. Although Wordmove is an awesome package, I don't think code editors will add some rules for
Movefile
I think it would bring some benefits and clarifications about the file format to Wordmove users:
- requires no extra editor configuration (adding a package, configuring it, etc.)
- automatic indentation detection (no need to mention some basic advices on yaml like those)
- automatic syntax highlighting in any editor
What do you think?
from wordmove.
Thanks for considering the request. Let me know when you will start doing this, I can provide some help with the docs (I suck at ruby).
from wordmove.
@pioneerskies Seems like no one have something to argue :)
Would you consider adding the yaml extension as the default behaviour?
from wordmove.
@nlemoine you are "lucky" I've got a cold and I'm in the bed with my headache and bored as hell...and so #424 :P
Tests are passing. I'm going to di a live test before merging on master.
from wordmove.
Sorry about that ^^ Hope you'll be better soon.
Thanks for taking care of this change. Since you're bored, sorry for being picky but could the default could be Movefile.yml
? The shorter extension is kind of a convention when using YAML files (Symfony, etc.) and keeping the capital M will probably handle better some retro compatiblity/OS filesystem edge cases and cause less trouble and misunderstanding around Wordmove users.
Let me know if I can help.
from wordmove.
Pls, let's discuss in the PR
from wordmove.
Related Issues (20)
- Enable / disable hook via .env HOT 4
- Question : Must --simulate option simulate database pulling (mysqldump) ? HOT 3
- Is this a typo ?? HOT 1
- Too many arguments error with vvv-wordmove HOT 3
- database pull fails at wp search-replace: "Error: This does not seem to be a WordPress installation." HOT 5
- censor database name, user and password in mysqldump invocation HOT 8
- WP login impossible after `pull -d`. Local installation redirects me to remote installation. HOT 4
- Database does not load on remote server when pushing from local HOT 2
- Mysqldump can't create/write to file
- "Error: This does not seem to be a WordPress installation" when using sql_adapter: wpcli HOT 3
- Error on pull: Calling `DidYouMean::SPELL_CHECKERS.merge!(error_name => spell_checker)' has been deprecated. HOT 4
- wordmove should ignore or warn about trailing slashes in 'vhost'
- DB pull fails with an JSON::ParserError error HOT 6
- 'Stack level too deep' error on Windows HOT 2
- Net::SSH::AuthenticationFailed when pulling db HOT 13
- SPELL_CHECKERS and psych-4.0.6 errors HOT 2
- net-ssh error when database move HOT 2
- Ruby error when pushing database over FTP HOT 2
- Password required on remote mysqldymp HOT 7
- Net:SSH AuthenticationFailed on remote mysqldump after rsync finished successfully HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wordmove.