Coder Social home page Coder Social logo

Ansible Integration about pvediscorddark HOT 3 CLOSED

weilbyte avatar weilbyte commented on September 27, 2024
Ansible Integration

from pvediscorddark.

Comments (3)

Weilbyte avatar Weilbyte commented on September 27, 2024

I am unfamiliar with Ansible since I use Salt myself so I don't see an Ansible role thing coming soon. Anyway I believe your config here has a few flaws, as I can see it waits for the installer file to update.

The PVEDiscordDark.py file is rarely changed, all it does is help in installing and uninstalling but it does not hold any of the important bits itself. It gets those from the GitHub instead.

https://github.com/Weilbyte/PVEDiscordDark/raw/master/PVEDiscordDark/sass/PVEDiscordDark.css being the CSS.
https://github.com/Weilbyte/PVEDiscordDark/raw/master/PVEDiscordDark/js/PVEDiscordDark.js being the JS.

So ideally you'd want to check if any of those 3 (incl. the installer) are changed and if they are then run the check/uninstall/install steps. So that should hopefully make it better.

However, your release tagging idea is great. As it is right now, you can force the installer to install from a specific repository branch by supplying it in a BRANCH environmental variable while running the installer. This, also works with tags, but for security reasons don't use the tag's name, use its commit hash (or the first 7 characters of it).

I have created a tag/release now.

from pvediscorddark.

djarbz avatar djarbz commented on September 27, 2024

Awesome, thanks. I will look into re-working my script to account for your suggestions.

from pvediscorddark.

djarbz avatar djarbz commented on September 27, 2024

I created a role here: https://github.com/djarbz/ansible-PVEDiscordDark

from pvediscorddark.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.