Comments (3)
I am unfamiliar with Ansible since I use Salt myself so I don't see an Ansible role thing coming soon. Anyway I believe your config here has a few flaws, as I can see it waits for the installer file to update.
The PVEDiscordDark.py
file is rarely changed, all it does is help in installing and uninstalling but it does not hold any of the important bits itself. It gets those from the GitHub instead.
https://github.com/Weilbyte/PVEDiscordDark/raw/master/PVEDiscordDark/sass/PVEDiscordDark.css
being the CSS.
https://github.com/Weilbyte/PVEDiscordDark/raw/master/PVEDiscordDark/js/PVEDiscordDark.js
being the JS.
So ideally you'd want to check if any of those 3 (incl. the installer) are changed
and if they are then run the check/uninstall/install steps. So that should hopefully make it better.
However, your release tagging idea is great. As it is right now, you can force the installer to install from a specific repository branch by supplying it in a BRANCH
environmental variable while running the installer. This, also works with tags, but for security reasons don't use the tag's name, use its commit hash (or the first 7 characters of it).
I have created a tag/release now.
from pvediscorddark.
Awesome, thanks. I will look into re-working my script to account for your suggestions.
from pvediscorddark.
I created a role here: https://github.com/djarbz/ansible-PVEDiscordDark
from pvediscorddark.
Related Issues (20)
- Missing icons for SDN HOT 1
- PVE 7.2 - Ceph Pools White Line HOT 1
- the cpu icon without theme on PVE7.2.3 HOT 1
- Add Support for Proxmox Backup Server HOT 4
- readme.md installation instructions HOT 1
- Proxmox 7.2-7 - Dark theme stopped working all of a sudden. It may be after an upgrade of PVE HOT 1
- Change Background-Color Pool Resource HOT 1
- Doesn't seem to work on 7.2-7 HOT 2
- new proxmox version update undid dark theme HOT 16
- [Theme] Nordigr HOT 2
- Oneliner not functoning HOT 2
- [Feature Request] Option For PBS [Proxmox Backup Server] HOT 1
- Summary Box has a different size than the rest
- contribution not worth a PR HOT 6
- 6.4 won't load dark colors HOT 1
- Theme not work HOT 5
- Switch to making the color scheme selectable in proxmox 7.4 HOT 9
- Support for Proxmox 7.4 (after release of "official" dark mode) - few issues with pvediscord dark HOT 8
- Color problem on graphics HOT 3
- Works on latest Proxmox VE (8.1.3) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pvediscorddark.