Coder Social home page Coder Social logo

Comments (13)

philiparthurmoore avatar philiparthurmoore commented on July 17, 2024

I don't think there's a way to do this. Unless I'm missing something I can only either hook into edit_form_top or edit_form_after_title.

from subtitles.

bryceadams avatar bryceadams commented on July 17, 2024

I haven't checked this yet either but will take a look tonight. If not, could make for a nice little patch to WP core. Will get back to you tonight :)

from subtitles.

bryceadams avatar bryceadams commented on July 17, 2024

So as you said it can't be done at the moment. I honestly think that edit_form_after_title is in the wrong position and should actually be after the title field itself but I doubt this will change. I've opened up a trac ticket for people to discuss it in.

I think adding a new hook in between .titlewrap and .inside would be nice - I've never made a core patch before so hopefully it's something I could do :)

from subtitles.

philiparthurmoore avatar philiparthurmoore commented on July 17, 2024

I've opened up a trac ticket for people to discuss it in.

Can you link to the ticket?

I've never made a core patch before so hopefully it's something I could do.

Sweet!

from subtitles.

bryceadams avatar bryceadams commented on July 17, 2024

Yep, 2 minutes. Just adding a patch as well

from subtitles.

bryceadams avatar bryceadams commented on July 17, 2024

Here is the ticket - https://core.trac.wordpress.org/ticket/29691#ticket

Making the patch now. I'm proposing to add the following in between those two divs:

<?php
/**
 * Fires before the permalink field
 *
 * @since 4.0.1
 *
 * @param WP_Post $post Post object.
 */
do_action( 'edit_form_before_permalink', $post );
?>

from subtitles.

bryceadams avatar bryceadams commented on July 17, 2024

Made a patch - https://core.trac.wordpress.org/ticket/29691

I hope I did it right! 🎉

from subtitles.

philiparthurmoore avatar philiparthurmoore commented on July 17, 2024

Waiting on Core to do anything here. Should be a very simple fix if your patch lands into WordPress.

from subtitles.

bryceadams avatar bryceadams commented on July 17, 2024

Fingers crossed. Not a big issue but it will make Subtitles look a lot better :)

from subtitles.

bryceadams avatar bryceadams commented on July 17, 2024

Looks like it will be in WordPress 4.1 :) When the time comes I'll create a branch and PR for this.

from subtitles.

philiparthurmoore avatar philiparthurmoore commented on July 17, 2024

Fantastic.
On Sep 18, 2014 4:43 PM, "Bryce Adams" [email protected] wrote:

Looks like it will be in WordPress 4.1 :) When the time comes I'll create
a branch and PR for this.


Reply to this email directly or view it on GitHub
#30 (comment)
.

from subtitles.

philiparthurmoore avatar philiparthurmoore commented on July 17, 2024

@bryceadams Thanks for bringing this up and submitting that Core patch. This will be ready when WordPress 4.1 lands.

from subtitles.

bryceadams avatar bryceadams commented on July 17, 2024

@philiparthurmoore thanks for pushing me make my first core contribution :)

from subtitles.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.