persistent state about webtorrent-desktop

[feross]

Currently avoiding anything that requires native dependencies or grows the dependency graph in a big way.

+1

I don't think we need to track that much. A plain object that's JSON.stringify()able will work fine for most of our state. https://github.com/LinusU/node-application-config looks great to me.

[feross]

I've generally been trying to put state that's ephemeral and can be thrown away on app exit into state.view. Stuff that's outside that (i.e. state.*) should be persisted to disk.

Right now, stuffs a bit disorganized there, but I think it's worth preserving a distinction here.

[ungoldman]

Maybe something like a state.session object would make sense to namespace all things that are session specific?

[ungoldman]

(thinking eventually other things will be session specific outside of managing view state)

[ungoldman]

Could use node-application-config to read/write from config to state.config too

[feross]

@ngoldman That sounds fine to me

[feross]

Why not use node-application-config to read/write the whole state object, minus state.session?

[ungoldman]

Whichever's easier 😜

[dcposch]

node-application-config looks jank. 2 stars on github, 43 downloads this week.

it also doesn't do file locking as far as i can tell, so there's nothing to prevent two instances of the app running and clobbering each other's state files

[feross]

@dcposch GitHub stars and downloads per week don't mean anything if the package works :)

I think it looks like a good start anyway, specifically how it stores state in the right OS-specific location: https://github.com/LinusU/node-application-config-path/blob/master/index.js

Maybe we can add locking in a PR?

[ungoldman]

Totally agree, it's not about the stars and downloads. That said, https://www.npmjs.com/package/application-config is the right package (not https://www.npmjs.com/package/node-application-config), which got about 11,353 downloads last month :)