Coder Social home page Coder Social logo

Comments (5)

xmuskrat avatar xmuskrat commented on June 8, 2024 1

So, this means that you choose to support 301 and 302 redirects, but not 307 redirects because clients can, but are not required, to follow 3xx standards? Sad, cause I'm hitting this same issue.

from websocket-client.

engn33r avatar engn33r commented on June 8, 2024

The link you provided is to the HTTP Semantics RFC, but the relevant text in the WebSockets hybi-13 spec that this repository supports is:

If the status code received from the server is not 101, the client handles the response per HTTP [RFC2616] procedures, in particular the client might perform authentication if it receives 401 status code, the server might redirect the client using a 3xx status code (but clients are not required to follow them), etc. Otherwise, proceed as follows.

from websocket-client.

engn33r avatar engn33r commented on June 8, 2024

The fix was provided in commit 69468ad but a new version has not been made yet. Please use the latest commit for this feature for now.

The text I provided before was clarification because the OP mentioned a RFC that was not the websocket RFC

from websocket-client.

jakublATopera avatar jakublATopera commented on June 8, 2024

I've had a feeling that since WebSocket RFC release, ws release didn't change, but HTTP protocol WS RFC refers to was changed with addition of mentioned status codes (307, 308), so I just pointed the HTTP change.
Thanks for fix.

from websocket-client.

engn33r avatar engn33r commented on June 8, 2024

@jakublATopera I forgot to push a new release last week, this is now fixed in 1.6.4

from websocket-client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.