Add adapter.js to Bower about samples

[KaptenJansson]

Are you talking about running locally on a branch that's not synced with the master? Or do you mean the static content on the gh-pages branches?

[piranna]

No, I'm talking about adapter.js is being used by a lot of third-party projects (for instance, at my job), so the only two solutions are to use a local copy updated by hand, or use RawGit. By registering it on Bower it can be updated and managed automatically.

[juberti]

Do you want to create a PR showing how to do this?

[piranna]

Hi @juberti, I've already registered the repo on Bower (it doesn't require any permissions and can be done by anybody since Bower registry works mostly as a URL shortener) and done a pull-request with the required bower.json metadata file so it's easily indexable and only download the adapter.js file and no others.

[samdutton]

Great idea – thanks. Will duly tweet/post.

If no objections will close this issue.

[piranna]

You are welcome @samdutton :-) Yes, this issue could be closed, it keeps remaining to accept the pull-request (or comment what needs to be fixed so it can be merged).

[piranna]

Any update on this? Is there any issue with the pull-request?

[samdutton]

Thanks for your suggestion and pull request – apologies for delay in dealing with this.

LGTM. We could add a Grunt task to check bower.json validity if necessary.

Any objections to merging, @juberti or @KaptenJansson?

[juberti]

I haven't taken the time to fully grok this but if it LGTY Sam go ahead.

[piranna]

apologies for delay in dealing with this.

Don't worry, I supposed you were busy :-)

We could add a Grunt task to check bower.json validity if necessary.

The content of the bower.json file will mostly don't change, since it
only host generic metadata for the Bower registry. What do you want to
validate and in what cases?

"Si quieres viajar alrededor del mundo y ser invitado a hablar en un
monton de sitios diferentes, simplemente escribe un sistema operativo
Unix."
– Linus Tordvals, creador del sistema operativo Linux

[samdutton]

The idea of adding a bower.json check is simply to make sure that
adapter.js stays where it should be.

No big deal – just (maybe) a nice to have.

On Thu, Nov 6, 2014 at 9:16 AM, Jesús Leganés Combarro <
[email protected]> wrote:

apologies for delay in dealing with this.

Don't worry, I supposed you were busy :-)

We could add a Grunt task to check bower.json validity if necessary.

The content of the bower.json file will mostly don't change, since it
only host generic metadata for the Bower registry. What do you want to
validate and in what cases?

"Si quieres viajar alrededor del mundo y ser invitado a hablar en un
monton de sitios diferentes, simplemente escribe un sistema operativo
Unix."
– Linus Tordvals, creador del sistema operativo Linux

—
Reply to this email directly or view it on GitHub
#104 (comment).

[piranna]

i don't understand how should the grunt script work, if you explain me I would give it a try.

[samdutton]

Which grunt script – the one for adding new code demos?

On Mon, Nov 10, 2014 at 11:31 AM, Jesús Leganés Combarro <
[email protected]> wrote:

i don't understand how should the grunt script work, if you explain me I
would give it a try.

—
Reply to this email directly or view it on GitHub
#104 (comment).

[piranna]

No, the one as a sanity check for the availability of the adapter.js file.
El 10/11/2014 12:42, "Sam Dutton" [email protected] escribió:

Which grunt script – the one for adding new code demos?

On Mon, Nov 10, 2014 at 11:31 AM, Jesús Leganés Combarro <
[email protected]> wrote:

i don't understand how should the grunt script work, if you explain me I
would give it a try.

—
Reply to this email directly or view it on GitHub
#104 (comment).

—
Reply to this email directly or view it on GitHub
#104 (comment).

[samdutton]

Ah – I meant this one: npmjs.org/package/grunt-bower-verify
https://www.npmjs.org/package/grunt-bower-verify.

On Mon, Nov 10, 2014 at 11:45 AM, Jesús Leganés Combarro <
[email protected]> wrote:

No, the one as a sanity check for the availability of the adapter.js file.
El 10/11/2014 12:42, "Sam Dutton" [email protected] escribió:

Which grunt script – the one for adding new code demos?

On Mon, Nov 10, 2014 at 11:31 AM, Jesús Leganés Combarro <
[email protected]> wrote:

i don't understand how should the grunt script work, if you explain me
I
would give it a try.

—
Reply to this email directly or view it on GitHub
<
https://github.com/GoogleChrome/webrtc/issues/104#issuecomment-62372345>.

—
Reply to this email directly or view it on GitHub
#104 (comment).

—
Reply to this email directly or view it on GitHub
#104 (comment).

[piranna]

Ah – I meant this one: npmjs.org/package/grunt-bower-verify

Didn't know of this package. Seems more focused to check that the
bower dependencies of a proyect are valid ones instead of validate
that the package itself is correct, isn't it?

"Si quieres viajar alrededor del mundo y ser invitado a hablar en un
monton de sitios diferentes, simplemente escribe un sistema operativo
Unix."
– Linus Tordvals, creador del sistema operativo Linux

[samdutton]

to check that the bower dependencies of a project are valid

Yes. I don't think we definitely have to validate the Bower dependencies –
I just happened to notice this package and thought it might be worthwhile
:).

I've merged your pull request.

Thanks again for doing this – excellent suggestion.

Sam

On Mon, Nov 10, 2014 at 12:43 PM, Jesús Leganés Combarro <
[email protected]> wrote:

Ah – I meant this one: npmjs.org/package/grunt-bower-verify

Didn't know of this package. Seems more focused to check that the
bower dependencies of a proyect are valid ones instead of validate
that the package itself is correct, isn't it?

"Si quieres viajar alrededor del mundo y ser invitado a hablar en un
monton de sitios diferentes, simplemente escribe un sistema operativo
Unix."
– Linus Tordvals, creador del sistema operativo Linux

—
Reply to this email directly or view it on GitHub
#104 (comment).

[piranna]

Thank you for accepting it, I think it will be useful :-)

One last note: I've check to download it on my machine and now it doesn't download the full repo (good! :-D ), but there are some pending useless files, maybe added after I did the pull-request:

[piranna@Latitude:/tmp/prueba]
 > tree
.
└── bower_components
    └── adapter.js
        ├── bower.json
        ├── Gruntfile.js
        ├── LICENSE
        ├── package.json
        ├── README.md
        └── samples
            └── web
                └── js
                    └── adapter.js

5 directories, 6 files

Gruntfile.js and package.json shouldn't be there. I can be able to do a pull-request to add them to the ignore field, but it's not absolutely necesary :-)

[samdutton]

Ah... good spot. Obviously Gruntfile.js, etc., aren't required for
adapter.js. Would be good to ignore.

(Gruntfile.js and package.json are used for build testing.)

On Mon, Nov 10, 2014 at 2:29 PM, Jesús Leganés Combarro <
[email protected]> wrote:

Thank you for accepting it, I think it will be useful :-)

One last note: I've check to download it on my machine and now it doesn't
download the full repo (good! :-D ), but there are some pending useless
files, maybe added after I did the pull-request:

[piranna@Latitude:/tmp/prueba]

tree.
└── bower_components
└── adapter.js
├── bower.json
├── Gruntfile.js
├── LICENSE
├── package.json
├── README.md
└── samples
└── web
└── js
└── adapter.js

5 directories, 6 files

Gruntfile.js and package.json shouldn't be there. I can be able to do a
pull-request to add them to the ignore field, but it's not absolutely
necesary :-)

—
Reply to this email directly or view it on GitHub
#104 (comment).

[piranna]

Here you have the updated bower.json file with Gruntfile.js and package.json on the ignore hash :-)

#200

[KaptenJansson]

This is done right?

[piranna]

Yes, this is already done, I'll close the issue. Thanks to everybody :-)