Coder Social home page Coder Social logo

Comments (4)

rainliu avatar rainliu commented on May 16, 2024

Yes, it is a bug in https://sourcegraph.com/github.com/webrtc-rs/turn/-/blob/src/client/relay_conn.rs?L212-218.

Will fix it soon.

from webrtc.

Andrepuel avatar Andrepuel commented on May 16, 2024

Besides that, there is no Lifetime tracking. If we didn't receive any packet from a given address for more than 300 seconds, then the Permission for that given address should be removed from the perm_map. Because we must update the permission.

Could you confirm this? Upon closer inspection I've found a reference to a timed refresh of permissions:

https://sourcegraph.com/github.com/webrtc-rs/turn@909eac74d669d62202cd89783ef7e6136e1f4026/-/blob/src/client/relay_conn.rs?L600

Does that mean we don't need to track permissions timeout?

from webrtc.

rainliu avatar rainliu commented on May 16, 2024

The bug of CreatePermission is called for every TURN packet sent should be fixed in commit # f593cc4d1940a9cbae03ff32d70b33d2f8bda969.

from webrtc.

Andrepuel avatar Andrepuel commented on May 16, 2024

The bug of CreatePermission is called for every TURN packet sent should be fixed in commit # f593cc4d1940a9cbae03ff32d70b33d2f8bda969.

I can confirm that this commit fixes the problem.

from webrtc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.