Coder Social home page Coder Social logo

Comments (3)

WebReflection avatar WebReflection commented on May 12, 2024 1

Are you trying to set text or HTML? If text, put at least one space around.

About null, I don't know if I want to end up handling dirty data. Why would have a null for a layout that accepts text on nodes or arrays as explained by the API? Those are also not the only place that need special handling for dirty data.

I'll think about it but it might be a won't-fix unless you provide me a good reason for accepting null values

from hyperhtml.

WebReflection avatar WebReflection commented on May 12, 2024 1

that's cool, but it also covers only one scenario.

hyperHTML templates accept 2 kind of values and their Array counterpart:

  1. a string, a DOM node (including document fragments)
  2. an array of strings, an Array of DOM nodes

Accepting dirty data means that I need to loop over all lists to see if one of those values and I don't think the job of this library is to sanitize its own signature.

So far I've built many examples, including a whole TodoMVC and the whole Hacker News and dirty data was unnecessary.

If you really need to handle that case, you can always explicitly opt in via ${model.prop || ''} whenever it's appropriate, which should be usually not the default behavior.

TL;DR unless there's evidence that everyone needs hyperHTML to be fatter and slower due dirty data, this can be considered a won't fix.

from hyperhtml.

joshgillies avatar joshgillies commented on May 12, 2024

Agree with you @WebReflection.

@pinguxx If you really want to solve the above issue might I suggest something I've been experimenting with inside hypercomponent - which is effectively wrapping hyperHTML.wire() in a function like:

function wrappedWire (...args) {
  return hyperHTML.wire(this).apply(hyperHTML, args.map((arg) =>
    typeof arg === 'undefined' || arg === null ? '' : arg))
}

// use it just like you would with any old wire
wrappedWire`<div>${ maybeUndefined }</div>`

In fact, the above is exactly how https://github.com/joshgillies/hyperrender works! 🎉

from hyperhtml.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.