Hi, this has made my life so much easier and I now start almost every new p

if you bundle this with anything else it might fails. As example, you bundle th

To be more precise, there is a reason I wrote this in <a href="https://github.com/WebR

Publish to npm? about domcontentloaded HOT 4 CLOSED

bjoerge commented on June 16, 2024

Publish to npm?

from domcontentloaded.

Comments (4)

WebReflection commented on June 16, 2024

if you bundle this script with anything else it might fails. As example, you bundle this via browserify and you load your bundle with async and goodbye functionality, it will not run as it should.

I think it would be wiser to put this directly in your most basic HTML template, would that work?

from domcontentloaded.

WebReflection commented on June 16, 2024

To be more precise, there is a reason I wrote this in the source code:

// DO NOT COPY AND PASTE IN ANY LIBRARY OR JS FILE
// this  MUST be the first script on top of **your** HTML page
// and it MUST be **included/executed only once**
// If your framework fix this already and every script in your page
// uses such framework then you don't need this script

from domcontentloaded.

bjoerge commented on June 16, 2024

Yeah, I'm aware of that. I'm thinking including it in the HTML template, something along the lines of:

var fs = require('fs')
var domContentLoadedSrc = fs.readFileSync(require.resolve('dom-content-loaded'))

//…

res.send(`<html><head><script>${domContentLoadedSrc}</script> …`)