Comments (4)
I'll fix it.
For the net
dependency: You can offer a fake net
module in the web_modules
folder so validator find it.
For the validator module you may provide also a isIP
method in the fake module.
// validator/lib/validators.js
// ...
isIP: function(str) {
// net.isIp requires node >= 0.3.0
var modernNode = typeof net.isIP === 'function';
var method = modernNode? validators.isIPNet : validators.isIPManual;
return method(str);
},
isIPNet: function(str) {
return net.isIP(str) !== 0;
},
// ...
from webpack.
It should work now.
from webpack.
Awesome! That was fast ;)
When will you publish a new version to npm?
And for the web_module thing: I've sent a pull request for node-validator which removed the net-dependency. I was aware of the web_module way but fixing it at the module itself seemed to make more sense, because other people might want to use the module with webpack and browserify as well.
from webpack.
I've publish it already, but it wasn't a change to webpack
but to a dependency of webpack enhanced-resolve
. That module care about the resolving process.
Therefore webpack provides a syntax for module authors to provide different versions of node.js and webpack. xxx.js
will be replaced with xxx.web.js
or xxx.webpack.js
.
validator could be organized this way:
// validators.js
var isIP = require("./isIP");
// isIP.js
module.exports = require("net").isIP;
// isIP.web.js
module.exports = function(str) {
// add some browser replacement here
}
I proposed it for browserify here already: browserify/browserify#174
from webpack.
Related Issues (20)
- Webpack build error for second time HOT 1
- `exportsPresence` does not work for unused imports HOT 3
- Implement ability to use "node:" prefixes for Node.js core modules HOT 1
- mangled exports breaks with destructuring assignment of JSON imports HOT 7
- there are confusing JDocs code
- Potential bug issues
- Webpack is not resolving node_modules specified in `resolve.modules` property.
- Dynamically loading chunks
- [Code implementation issues] ArrayQueue
- [feature] create cli HOT 3
- Not able to build node script
- bootstrap:27 Uncaught TypeError: __webpack_require__.nmd is not a function
- Self-reference dependency has unused export name when imported inside of a web worker
- support `import.meta.dirname` and `import.meta.filename` HOT 2
- <!-- identifier: admin-actions -->
- Remote into Web Component from React giving an error saying " Module does not exist in container"
- Multiple DefinePlugin instances cause aggressive cache invalidation due to collisions HOT 7
- Webpack fails when importing module
- import .scss build to js, the exported mapping is inconsistent with the usage【Urgent!!】
- Unused code elimination and deduplication is not applied when using sass's api: 'legacy' setting
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from webpack.