Coder Social home page Coder Social logo

Comments (5)

AviVahl avatar AviVahl commented on June 12, 2024

@alexander-akait I believe this is a regression from these changes: https://github.com/webpack/webpack-dev-middleware/pull/1260/files#diff-093ad82a25aee498b11febf1cdcb6546e4d223ffcb49ed69cc275ac27ce0ccce

from webpack-dev-middleware.

luoguoxiong avatar luoguoxiong commented on June 12, 2024

I have the same problem~

from webpack-dev-middleware.

nuintun avatar nuintun commented on June 12, 2024

+1

type API<
Request_1 extends import("http").IncomingMessage,
Response_1 extends ServerResponse
> = Middleware<Request, Response> & AdditionalMethods<Request, Response>;

Request_1 and Response_1 generic definition is unused.

from webpack-dev-middleware.

alexander-akait avatar alexander-akait commented on June 12, 2024

@AviVahl Weird, we don't touch ts files, just update deps, maybe regression in ts?

from webpack-dev-middleware.

alexander-akait avatar alexander-akait commented on June 12, 2024

Found ts regression, when you have:

/**
 * @template {IncomingMessage} Request
 * @template {ServerResponse} Response
 * @typedef {Object} Options
 * @property {{[key: string]: string}} [mimeTypes]
 * @property {boolean | ((targetPath: string) => boolean)} [writeToDisk]
 * @property {string} [methods]
 * @property {Headers<Request, Response>} [headers]
 * @property {NonNullable<Configuration["output"]>["publicPath"]} [publicPath]
 * @property {Configuration["stats"]} [stats]
 * @property {boolean} [serverSideRender]
 * @property {OutputFileSystem} [outputFileSystem]
 * @property {boolean | string} [index]
 */

ts 4.6 consider Request and Response as global classes in dom.lib.ts (as @AviVahl mention), not as local generics, very weird, let's downdgrade and fix types and report

from webpack-dev-middleware.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.