Coder Social home page Coder Social logo

Comments (10)

SpaceK33z avatar SpaceK33z commented on May 2, 2024 4

@dignifiedquire okay, without breaking changes we can publish this as a minor version. Yes publishing it on npm and opening a PR would be a good idea. Note that I don't maintain this repo myself, but I'll try to get some others on it after your PR.

from node-libs-browser.

daviddias avatar daviddias commented on May 2, 2024 1

beep boop. Can we get an update from the devs on this? Thank you!

from node-libs-browser.

wires avatar wires commented on May 2, 2024 1

Bump ;)
Ran into this, would be nice if it can get merged and released cheers 👍

from node-libs-browser.

daviddias avatar daviddias commented on May 2, 2024

The number of bug reports that modules are broken with a zlib error keeps increasing and simply because we can't force WebPack builds to use ipfs/browserify-zlib in the same we do to replace other modules that are loaded into the browser, it is super painful to everyone.

from node-libs-browser.

haadcode avatar haadcode commented on May 2, 2024

Merging this would be hugely beneficial for the https://github.com/ipfs/js-ipfs project.

We're currently working towards supporting https://github.com/facebookincubator/create-react-app which doesn't support custom webpack configs. As js-ipfs in itself uses a fork of browserify-zlib, we need to include it in our build tools (https://github.com/dignifiedquire/aegir/blob/master/config/webpack.js#L35). As such, we're not able to have create-react-app compile code that uses js-ipfs, because we can't include the fork :/ I hope this makes sense, but let me know if clarification is needed.

If there's anything I (and we) can do to get closer to merging this, please let us know.

from node-libs-browser.

SpaceK33z avatar SpaceK33z commented on May 2, 2024

@haadcode for us it's important to know if there are breaking changes in the new library compared to the curret one and if so, which one. Also a PR implementing this would be appreciated.

from node-libs-browser.

dignifiedquire avatar dignifiedquire commented on May 2, 2024

@SpaceK33z thank you for the response. There should not be any breaking changes, only bug fixes and feature additions. I looked through the changelogs again and there where no breaking changes listed for zlib in v4, v5 or v6

If there is interest in shipping this I would publish the fork to npm on a new name and open a PR here. That change would only consist in changing the name of the zlib dependency and its version.

from node-libs-browser.

daviddias avatar daviddias commented on May 2, 2024

@dignifiedquire go ahead and publish it to npm, name suggestion browserify-zlib-complete :)

from node-libs-browser.

dignifiedquire avatar dignifiedquire commented on May 2, 2024

Published https://www.npmjs.com/package/browserify-zlib-next and created PR #52

from node-libs-browser.

dignifiedquire avatar dignifiedquire commented on May 2, 2024

This is fixed in [email protected]: http://npmjs.com/browserify-zlib

from node-libs-browser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.