Coder Social home page Coder Social logo

Comments (10)

ypconstante avatar ypconstante commented on July 24, 2024 1

There is any progress to fix this bug? I'm trying to migrate a project to webpack and I spent some hours trying to figure out what I was doing wrong and in the end it was this incompatibility between NamedModulesPlugin and expose-loader.

from expose-loader.

sokra avatar sokra commented on July 24, 2024

That's a bug in libIdent webpack/webpack.

from expose-loader.

WiseBird avatar WiseBird commented on July 24, 2024

@sokra Should I refile it there?

from expose-loader.

ypconstante avatar ypconstante commented on July 24, 2024

Some other issues related this bug:

The extract-text-webpack-plugin issue was fixed, maybe the fix is similar.

from expose-loader.

cansin avatar cansin commented on July 24, 2024

I tried to look at how extract-text-webpack-plugin got fixed to understand whether a similar pattern can be applied to expose-loader. But honestly, I have no idea. I hope someone that is familiar with either can send a patch PR soon.

from expose-loader.

cansin avatar cansin commented on July 24, 2024

Actually the problem expose-loader encountering might be different from what extract-text-webpack-plugin is having (based on webpack-contrib/extract-text-webpack-plugin#648 (comment) ).

from expose-loader.

cansin avatar cansin commented on July 24, 2024

So a patch to webpack/webpack (as described at webpack/webpack#4613 (comment) ) "fixes" this issue. But I think such a patch would also mess up with the consistent hashing for long-term caching since for the modules skipped hashing would be non-deterministic (I think). But I am not sure. I am hoping @sokra would weigh in.

from expose-loader.

timse avatar timse commented on July 24, 2024

just saw this after opening #58 sorry for that :P.

The issue probably should be handled by webpack?

probably modules created in the pitch phase should by default get a new userRequest

from expose-loader.

cansin avatar cansin commented on July 24, 2024

@timse thanks for #58 ! That would at least unblock everyone while the underlying issue gets fixed at https://github.com/webpack/webpack .

from expose-loader.

adrielwerlich avatar adrielwerlich commented on July 24, 2024

Module build failed: TypeError: this.query.substr is not a function
at Object.module.exports.pitch (...\node_modules\expose-loader\index.js:43:34)

What about this message?

from expose-loader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.