Comments (10)
There is any progress to fix this bug? I'm trying to migrate a project to webpack and I spent some hours trying to figure out what I was doing wrong and in the end it was this incompatibility between NamedModulesPlugin and expose-loader.
from expose-loader.
That's a bug in libIdent
webpack/webpack.
from expose-loader.
@sokra Should I refile it there?
from expose-loader.
Some other issues related this bug:
The extract-text-webpack-plugin issue was fixed, maybe the fix is similar.
from expose-loader.
I tried to look at how extract-text-webpack-plugin
got fixed to understand whether a similar pattern can be applied to expose-loader
. But honestly, I have no idea. I hope someone that is familiar with either can send a patch PR soon.
from expose-loader.
Actually the problem expose-loader
encountering might be different from what extract-text-webpack-plugin
is having (based on webpack-contrib/extract-text-webpack-plugin#648 (comment) ).
from expose-loader.
So a patch to webpack/webpack
(as described at webpack/webpack#4613 (comment) ) "fixes" this issue. But I think such a patch would also mess up with the consistent hashing for long-term caching since for the modules skipped hashing would be non-deterministic (I think). But I am not sure. I am hoping @sokra would weigh in.
from expose-loader.
just saw this after opening #58 sorry for that :P.
The issue probably should be handled by webpack?
probably modules created in the pitch phase should by default get a new userRequest
from expose-loader.
@timse thanks for #58 ! That would at least unblock everyone while the underlying issue gets fixed at https://github.com/webpack/webpack .
from expose-loader.
Module build failed: TypeError: this.query.substr is not a function
at Object.module.exports.pitch (...\node_modules\expose-loader\index.js:43:34)
What about this message?
from expose-loader.
Related Issues (20)
- Options missing in third-party loader HOT 34
- Cannot expose ts module since 1.0.0 HOT 4
- Issue with alias while exposing private module HOT 1
- Webpack omits exposed modules when sideEffects are enabled HOT 15
- ! vs | HOT 14
- Cant get new versions of expose-loader to work HOT 8
- Unable to expose jQuery HOT 4
- expose-loader works in Chrome but not FireFox? HOT 9
- Docs Mismatch and Absolutely no "local" Examples HOT 1
- opt out of development thrown error HOT 5
- Exposing a class converts it to an esmodule object HOT 2
- webpack and webpack --watch will get different output HOT 1
- jQuery is not being exposed HOT 5
- Doesn't work as expected when exposing @apollo/client HOT 26
- Customizing the runtime getGlobalThis HOT 2
- Support namespace import
- Exposing ES6 modules without the default property HOT 2
- Webpack sometimes skips modules loaded through expose-loader when tree shaking is enabled HOT 2
- File hashes change between OSs when using expose-loader to replace jQuery and $ HOT 2
- expose-loader not working correctly with webpack 4 HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from expose-loader.